Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent output of schema.org meta script if empty array #4860

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Prevent output of schema.org meta script if empty array #4860

merged 1 commit into from
Jun 16, 2020

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Jun 16, 2020

Summary

Fixes #4783.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Jun 16, 2020
@github-actions
Copy link
Contributor

Plugin builds for 1a1b7da are ready 🛎️!

@westonruter westonruter added this to the v1.5.4 milestone Jun 16, 2020
@westonruter westonruter merged commit 07b5f14 into develop Jun 16, 2020
@westonruter westonruter deleted the enhancement/4783-empty-schema-org-metadata branch June 16, 2020 03:04
westonruter pushed a commit that referenced this pull request Jun 16, 2020
@pierlon @westonruter
Prevent output of schema.org meta script if filtered metadata array i…
95f0e2a 
…s empty (#4860)
@schlessera schlessera added the WS:Perf Work stream for Metrics, Performance and Optimizer label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@schlessera schlessera Awaiting requested review from schlessera

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA WS:Perf Work stream for Metrics, Performance and Optimizer
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging this pull request may close these issues.

Filtering Schema.org metadata to empty value results in empty JSON added to page
4 participants
@pierlon @westonruter @schlessera @googlebot