-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch the PHP-CSS-Parser library to correctly validate the turn
unit
#5392
Conversation
Plugin builds for 55bdab0 are ready 🛎️!
|
composer.lock
Outdated
"packages": [ | ||
{ | ||
"name": "ampproject/common", | ||
"version": "dev-develop", | ||
"version": "dev-fix/4604-parse-turn-unit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to have modified the Composer lock file so that it points to this branch for its libraries. I think that that will break as soon as this is merged, as the composer install
will not be able to find the branch that is being referenced in the lock file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be caused by the recent change I did to avoid locking the libraries to a branch so we can cross the v2 branch barrier...
What exactly did you run? Only a composer update
in the root folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly did you run? Only a composer update in the root folder?
Yep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from Slack:
Ok, I got a usable lock file now. However, I did it by running
composer update
fromdev-develop
after having deleted thevendor
folder. Then I changed into thefix/4604-parse-turn-unit
branch and re-rancomposer update
without deleting thevendor
folder.
Changes check out. I tried creating a Web Story with a gradient:
Also tried adding the test HTML on #4604, here after waiting a couple seconds:
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Summary
Applies the changes from MyIntervals/PHP-CSS-Parser#193 as a patch to be made to the PHP-CSS-Parser library.
Fixes #4604
Checklist