-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.1] Add Composer plugin to correctly autoload PHP CSS Parser dependency #6472
Conversation
Co-authored-by: Weston Ruter <westonruter@google.com>
Plugin builds for bca6e68 are ready 🛎️!
|
I've traced the E2E JS test failures to the latest Gutenberg release (v11.1.0). Whenever a test navigates to the Onboarding Wizard screen the Gutenberg plugin throws an error on the page because the admin bar is not present on the page, which causes puppeteer to lose its mind and bail for some reason. I've filed an issue on their repo (see WordPress/gutenberg#33591) to see how best that can be resolved. In the interim I think we can temporarily fix these E2E tests by using and pinning the last Gutenberg release (v11.0.0), as it won't throw the error. Also note this affects the |
Weirdly puppeteer doesn't bail and runs all tests to completion, although it does emit similar errors: That's most likely due to the |
Will you open a PR to do this for |
Yep sure. |
QA Passed In the 2.1 branch, the Lines 202 to 212 in 4205e6e
This corresponds with #6464 (comment). |
Summary
Backport of #6464.
Checklist