Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Site Scan Feature #6610

Merged
merged 122 commits into from
Oct 28, 2021
Merged

Add Site Scan Feature #6610

merged 122 commits into from
Oct 28, 2021

Commits on Oct 25, 2021

  1. Configuration menu
    Copy the full SHA
    1e6878f View commit details
    Browse the repository at this point in the history
  2. Add ProgressBar component

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    79af03d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4bd7a32 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df37573 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b84e7b0 View commit details
    Browse the repository at this point in the history
  6. Apply suggestions from code review

    Co-authored-by: Weston Ruter <westonruter@google.com>
    delawski and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    241e1b8 View commit details
    Browse the repository at this point in the history
  7. Revert "Refactor validation endpoint to allow validating by URL"

    This reverts commit 8cfa8be.
    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    5bd0575 View commit details
    Browse the repository at this point in the history
  8. Fix issues and update docs

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    97dfb1f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8815b9a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    900503f View commit details
    Browse the repository at this point in the history
  11. Improve scan progress animation

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    947ba18 View commit details
    Browse the repository at this point in the history
  12. Add checked page labels

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    29c2e28 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    577ccac View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9bc44c0 View commit details
    Browse the repository at this point in the history
  15. Add missing snapshot

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a88316a View commit details
    Browse the repository at this point in the history
  16. Add SourcesList sub-component

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    f834380 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    fbe3bf3 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    96438ba View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    bfd3d5f View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    7b7f296 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    bbaaac0 View commit details
    Browse the repository at this point in the history
  22. Fix stylelint issue

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a648443 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    49cf60e View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    a42e8c3 View commit details
    Browse the repository at this point in the history
  25. Revert debug code

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    3812189 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    c0a18af View commit details
    Browse the repository at this point in the history
  27. Minor code cleanup

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    e500f70 View commit details
    Browse the repository at this point in the history
  28. Fix phpcs issues

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    c3f616c View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    3171385 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    1ab1b73 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    faea80f View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    bdba451 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    147a5f1 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    c0f1183 View commit details
    Browse the repository at this point in the history
  35. Use correct icon in Site Scan panel

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    9fa9146 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    e2b6f14 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    58d1b48 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    695fe03 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    6e47aa6 View commit details
    Browse the repository at this point in the history
  40. Construct AMP validation URL on the client-side

    - Use `amp-first` query arg to force validation in Standard mode
    - Use `omit_stylesheet` and `cache` flags
    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a300ffb View commit details
    Browse the repository at this point in the history
  41. Revamp site scan context provider and UI components

    - Replace `useState`s with a single `useReducer`
    - Colocate site-scan-related sub-components
    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    4d5e265 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    98bc435 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    f861d55 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    ebfeaf2 View commit details
    Browse the repository at this point in the history
  45. Fix lint errors

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    1ccee27 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    5c65e55 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    428be92 View commit details
    Browse the repository at this point in the history
  48. Swap conditions

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    6ec0572 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    290d42f View commit details
    Browse the repository at this point in the history
  50. Remove redundant constant and prop

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    54223a3 View commit details
    Browse the repository at this point in the history
  51. Minor styling updates

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    d77ce62 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    5557da3 View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    a8e4719 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    ee14171 View commit details
    Browse the repository at this point in the history
  55. Remove needless condition

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    f1ae8e6 View commit details
    Browse the repository at this point in the history
  56. Fix JS lint issue

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    e136b4b View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    ceeb40b View commit details
    Browse the repository at this point in the history
  58. Apply suggestions from code review

    Co-authored-by: Weston Ruter <westonruter@google.com>
    delawski and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    8c1350c View commit details
    Browse the repository at this point in the history
  59. Simplify site scan reducer and add failed scan state

    - Store validation errors directly inside the `scannableUrl` array and derive theme and plugin issues, and staleness flag from that array.
    - Store HTTP request errors in the state so that it's possible to find out if the entire scan was unsuccessful (every `scannableUrl` has an `error` set).
    - Handle `isFailed` status in the UI.
    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    25a552a View commit details
    Browse the repository at this point in the history
  60. Preload themes and plugins data

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    3994353 View commit details
    Browse the repository at this point in the history
  61. Fix JS test

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    4dd1fcb View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    7b51924 View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    16d7038 View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    73156df View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    00d34b6 View commit details
    Browse the repository at this point in the history
  66. Add missing useEffect dependency

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    7e6ec7e View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    3c36262 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    95e74d8 View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    b53c7bd View commit details
    Browse the repository at this point in the history
  70. Configuration menu
    Copy the full SHA
    745039e View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    61f958c View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    95b7f93 View commit details
    Browse the repository at this point in the history
  73. Configuration menu
    Copy the full SHA
    19bed46 View commit details
    Browse the repository at this point in the history
  74. Configuration menu
    Copy the full SHA
    c1f5f41 View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    640c81b View commit details
    Browse the repository at this point in the history
  76. Configuration menu
    Copy the full SHA
    ce4d1c6 View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    4985064 View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    54ce73c View commit details
    Browse the repository at this point in the history
  79. Configuration menu
    Copy the full SHA
    b3c00ea View commit details
    Browse the repository at this point in the history
  80. Configuration menu
    Copy the full SHA
    220fd8c View commit details
    Browse the repository at this point in the history
  81. Configuration menu
    Copy the full SHA
    37eeac8 View commit details
    Browse the repository at this point in the history
  82. Configuration menu
    Copy the full SHA
    cd7fb88 View commit details
    Browse the repository at this point in the history
  83. Address code review feedback

    delawski authored and westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    70fcc43 View commit details
    Browse the repository at this point in the history
  84. Merge branch 'add/validate-store-url-query-var' into feature/4719-sit…

    …e-scan
    
    * add/validate-store-url-query-var:
      Improve tests for send_validate_response
      Add test for maybe_send_cached_validate_response
      Test omission of stylesheets in send_validate_response
      Replace redundante staleness with revalidated prop
      Move logic into maybe_send_cached_validate_response method
      Introduce args for validate requests to cache, serve cached, and omit stylesheets
      Add test coverage for AMP-first override requests
      Improve send_validate_response logic and add test coverage
      Move validate logic to validation manager
      Revert "Add amp_available_override query param to force AMP to be available"
      Adopt the Web Stories approach of selectively enabling Standard mode
      WIP: Try facilitating selective AMP-first URLs when in paired mode
      Add amp_available_override query param to force AMP to be available
      Remove needless pretty-printing of validation response
      Use constant for amp_store query param
      fixup! Allow validate requests to also store results
      Make is_validate_request a public method and member var protected
      Allow validate requests to also store results
    westonruter committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    ddeb234 View commit details
    Browse the repository at this point in the history
  85. Configuration menu
    Copy the full SHA
    0e134aa View commit details
    Browse the repository at this point in the history
  86. Configuration menu
    Copy the full SHA
    74b82c0 View commit details
    Browse the repository at this point in the history
  87. Configuration menu
    Copy the full SHA
    d1db12c View commit details
    Browse the repository at this point in the history
  88. Configuration menu
    Copy the full SHA
    b0d446a View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Merge branch 'develop' of github.com:ampproject/amp-wp into feature/4…

    …719-site-scan
    
    * 'develop' of github.com:ampproject/amp-wp:
      Remove extraneous action priority
    westonruter committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    32bf22a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7403381 View commit details
    Browse the repository at this point in the history
  3. Apply suggestions from code review

    Co-authored-by: Weston Ruter <westonruter@google.com>
    delawski and westonruter authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    3eba944 View commit details
    Browse the repository at this point in the history
  4. Fix comment alignment

    delawski authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    2c66292 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    65fc288 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cfcbc92 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a797f78 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7ad3998 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5ed62f8 View commit details
    Browse the repository at this point in the history
  10. Always allow re-running Site Scan

    It also improves the logic that renders Site Scan info notices.
    delawski committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    1313a0f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    16586ff View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    dcd9a44 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2b02071 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d5a3103 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3f80f6e View commit details
    Browse the repository at this point in the history
  16. Remove unused imports

    delawski committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    22ec597 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Improve logic for getting plugin slug from file path

    Co-authored-by: Weston Ruter <westonruter@google.com>
    delawski and westonruter authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    021df6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    68011a8 View commit details
    Browse the repository at this point in the history
  3. Update "Validated URLs" link text

    Co-authored-by: Weston Ruter <westonruter@google.com>
    delawski and westonruter authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    4b4d7ea View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bd39a6e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7d2f1d1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cf218ea View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    27a11e2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4cb3597 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    807532c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c83a2a9 View commit details
    Browse the repository at this point in the history
  11. Disable Template Mode E2E tests on AMP Settings screen

    Reason: the Template Mode recommendation logic underwent an overhaul when Site Scan feature had been added. New, tests that would be shared between the Settings screen and the Onboarding Wizard need to be written.
    delawski committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    cc9653c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    891b1d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Configuration menu
    Copy the full SHA
    7920d78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5073e8b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4a9f875 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9949c8a View commit details
    Browse the repository at this point in the history
  5. Add missing comma

    delawski committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    88a1fd9 View commit details
    Browse the repository at this point in the history
  6. Try fixing E2E tests

    delawski committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    8836b54 View commit details
    Browse the repository at this point in the history