Downgrade package-lock.json
back to v1
#6618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As @westonruter pointed out, the
.nvmrc
points to thelts
version of node, which would install node v14 and npm v6 by default. However, thepackage-lock.json
is using the v2 syntax which is generated by npm v7 (and later). Attempting to runnpm install
with npm v6 causes thepackage-lock.json
to produce a massive diff as it downgrades the lockfile back to v1.Also to note, Gutenberg and WP Core also currently use npm v6 and have their
package-lock.json
files in v1 format. Downgrading our lockfile to v1 to align with theirs will allow us developers to work across these projects without much hassle.Checklist