Add skip link for Full Site Editing themes #6823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 03f03d8 are ready 🛎️!
|
Codecov Report
@@ Coverage Diff @@
## develop #6823 +/- ##
=============================================
+ Coverage 78.31% 78.33% +0.02%
- Complexity 6708 6713 +5
=============================================
Files 202 202
Lines 20210 20236 +26
=============================================
+ Hits 15827 15852 +25
- Misses 4383 4384 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
delawski
requested changes
Jan 21, 2022
…skip-link * 'develop' of github.com:ampproject/amp-wp: (43 commits) Ensure Navigation block script is registered to fix tests Add missing test coverage for dequeue_block_navigation_view_script Use function exists check for render_block_core_navigation to determine if test should be skipped Add attribute value escaping for good measure Fix phpcs warnings Fix indentation Add assertions that no SQL queries run when data deletion is disabled Add test specifically for transient deletion Harden term deletion logic for WP<4.4 Add assertions for term deletion Flesh out tests specifically for post and term deletion Add test specific to delete_user_metadata Add test specifically for the delete_options function Remove deletion of non-option Add test assertions for terms table Use constant for taxonomy slug in test Add formatting for SQL statements Normalize config.allow-plugins in composer.json Update database queries to delete data during uninstalltion Revert changes from delete_user_metadata() ...
westonruter
reviewed
Jan 26, 2022
| return; | ||
| } | ||
|
|
||
| $skip_link_target = $this->dom->getElementId( $main_tag, 'wp--skip-link--target' ); |
There was a problem hiding this comment.
Good use of getElementId.
Why the extra hyphens? Why not just:
Suggested change
| $skip_link_target = $this->dom->getElementId( $main_tag, 'wp--skip-link--target' ); | |
| $skip_link_target = $this->dom->getElementId( $main_tag, 'wp-skip-link-target' ); |
There was a problem hiding this comment.
I think the double hyphens are here to match the JS implementation you'll find in Gutenberg:
There was a problem hiding this comment.
That being said, I just noticed that AMP adds a suffix to the skip link ID attribute (e.g. wp--skip-link--target-0). So it seems that the ID attributes won't be the same on AMP and on non-AMP versions. I guess it doesn't matter in any way.
delawski
approved these changes
Jan 26, 2022
westonruter
changed the title
westonruter
added a commit
that referenced
this pull request
Jan 26, 2022
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6115
This PR adds a skip link for full site editing themes without causing AMP compatibility issues. The PR uses the similar approach implemented in WordPress/gutenberg#30336 but in PHP.
Checklist