Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of dangerouslySetInnerHTML with createInterpolateElement #7000

Merged
merged 7 commits into from
Apr 20, 2022
Merged

Replace use of dangerouslySetInnerHTML with createInterpolateElement #7000

merged 7 commits into from
Apr 20, 2022

Conversation

dhaval-parekh
Copy link
Collaborator

@dhaval-parekh dhaval-parekh commented Mar 28, 2022 •
edited
Loading

Summary

Fixes #6759

Replace use of dangerouslySetInnerHTML with createInterpolateElement

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh marked this pull request as ready for review March 28, 2022 07:20
@westonruter westonruter added this to the v2.2.3 milestone Mar 29, 2022
@westonruter westonruter modified the milestones: v2.2.3, v2.2.4, 2.2.5 Apr 6, 2022
@maitreyie-chavan maitreyie-chavan modified the milestones: v2.2.5, v2.3 Apr 14, 2022
@milindmore22
Copy link
Collaborator

@dhaval-parekh please resolve merge conflicts

@dhaval-parekh dhaval-parekh force-pushed the enhancement/remove-dangerouslySetInnerHTML branch from bc7198a to 1e9bf82 Compare April 19, 2022 12:11
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2022 •
edited
Loading

Plugin builds for e3134fd are ready 🛎️!

@lgtm-com
Copy link

lgtm-com bot commented Apr 19, 2022

This pull request introduces 1 alert when merging 1e9bf82 into 326d057 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

milindmore22
milindmore22 approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@milindmore22 milindmore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

westonruter
westonruter requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great improvement! Just a couple nits to address.

assets/src/components/amp-support/index.js Show resolved Hide resolved
assets/src/components/template-mode-option/index.js Show resolved Hide resolved
assets/src/onboarding-wizard/pages/template-mode/index.js Outdated Show resolved Hide resolved
assets/src/settings-page/analytics.js Outdated Show resolved Hide resolved
assets/src/settings-page/analytics.js Outdated Show resolved Hide resolved
assets/src/settings-page/plugin-suppression.js Show resolved Hide resolved
@westonruter
Copy link
Member

westonruter commented Apr 19, 2022 •
edited
Loading

BTW: PR 7,000 🎉

westonruter
westonruter approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I love it.

@westonruter westonruter merged commit 724a933 into develop Apr 20, 2022
@westonruter westonruter deleted the enhancement/remove-dangerouslySetInnerHTML branch April 20, 2022 16:59
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milindmore22 milindmore22 milindmore22 approved these changes

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.

Replace dangerouslySetInnerHTML with createInterpolateElement in React apps
4 participants
@dhaval-parekh @milindmore22 @westonruter @maitreyie-chavan