Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lightbox effect if images are aligned #7178

Merged
merged 13 commits into from
Aug 3, 2022
Merged

Fix lightbox effect if images are aligned #7178

merged 13 commits into from
Aug 3, 2022

Commits on Jul 29, 2022

  1. Fix get attributes from node for Lightbox effect

    @thelovekesh
    thelovekesh committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    030c629 View commit details
    Browse the repository at this point in the history

  2. Remove Method AMP_Img_Sanitizer::does_node_have_block_class()

    @thelovekesh
    thelovekesh committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    a33d905 View commit details
    Browse the repository at this point in the history

  3. Remove test cases for method AMP_Img_Sanitizer::does_node_have_block_… 

    …class()
    @thelovekesh
    thelovekesh committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    1a28630 View commit details
    Browse the repository at this point in the history

  4. Fix test cases for setting lightbox attributes in img element

    @thelovekesh
    thelovekesh committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    f52f87c View commit details
    Browse the repository at this point in the history

  5. Fix comments formatting 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    58ddb10 View commit details
    Browse the repository at this point in the history

  6. Remove passed node_attributes

    @thelovekesh
    thelovekesh committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    2afd1ff View commit details
    Browse the repository at this point in the history

  7. Update logic to determine image src attribute from node attribute 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    ce76528 View commit details
    Browse the repository at this point in the history

  8. Update html element names with element interface props 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    16e57b0 View commit details
    Browse the repository at this point in the history

  9. Fix Static Analysis issue

    @thelovekesh
    thelovekesh committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    3e3dfdf View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Add test cases for maybe_add_lightbox_attributes method

    @thelovekesh
    thelovekesh committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    2cfc899 View commit details
    Browse the repository at this point in the history

  2. Add more use cases in data provider

    @thelovekesh
    thelovekesh committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    97cace9 View commit details
    Browse the repository at this point in the history

  3. Remove vague logic

    @thelovekesh
    thelovekesh committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    54baf60 View commit details
    Browse the repository at this point in the history

  4. Remove vague condition that return attributes

    @thelovekesh
    thelovekesh committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    1131c4d View commit details
    Browse the repository at this point in the history