Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Incorrect assumption of hex input by ReaderThemeSupportFeatures::get_relative_luminance_from_hex() #7286

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Fix Incorrect assumption of hex input by ReaderThemeSupportFeatures::get_relative_luminance_from_hex() #7286

merged 4 commits into from
Oct 6, 2022

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Oct 4, 2022 •
edited
Loading

Summary

When color value passed as RGB value or as a CSS variable hexdec() throws an error. This PR aims to add a guard to avoid passing such color values to avoid any errors.

Fixes #7285

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh self-assigned this Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022 •
edited
Loading

Plugin builds for b321f60 are ready 🛎️!

westonruter
westonruter approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@westonruter westonruter added this to the v2.3.1 milestone Oct 6, 2022
@westonruter westonruter merged commit 5a45909 into develop Oct 6, 2022
@westonruter westonruter deleted the fix/hexdec-errors branch October 6, 2022 18:19
@westonruter westonruter modified the milestones: v2.3.1, v2.4 Jan 26, 2023
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

@thelovekesh thelovekesh

Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

Incorrect assumption of hex input by ReaderThemeSupportFeatures::get_relative_luminance_from_hex()
2 participants
@thelovekesh @westonruter