Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SiteScanContextProvider's getSourcesFromScannableUrls() to handle null validationError.sources #7406

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Fix SiteScanContextProvider's getSourcesFromScannableUrls() to handle null validationError.sources #7406

merged 2 commits into from
Jan 11, 2023

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jan 11, 2023 •
edited
Loading

Summary

Fixes #7380

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh self-assigned this Jan 11, 2023
@thelovekesh thelovekesh added the Bug Something isn't working label Jan 11, 2023
@thelovekesh thelovekesh marked this pull request as draft January 11, 2023 14:26
@thelovekesh thelovekesh marked this pull request as ready for review January 11, 2023 14:27
@github-actions
Copy link
Contributor

Plugin builds for 28920ec are ready 🛎️!

@milindmore22 milindmore22 mentioned this pull request Jan 11, 2023
Closed
@westonruter westonruter added this to the v2.3.1 milestone Jan 11, 2023
@westonruter westonruter merged commit ecb4850 into develop Jan 11, 2023
@westonruter westonruter deleted the fix/site-scan-context-provider branch January 11, 2023 17:57
@westonruter westonruter modified the milestones: v2.3.1, v2.4 Jan 26, 2023
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

@thelovekesh thelovekesh

Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

AMP setting breaks with WooCommerce and TwentyTwentytwo theme.
2 participants
@thelovekesh @westonruter