Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display mobile switcher link when mobile redirection is disabled #7426

Merged
merged 8 commits into from
Jan 26, 2023
Merged

Display mobile switcher link when mobile redirection is disabled #7426

merged 8 commits into from
Jan 26, 2023

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jan 25, 2023 •
edited
Loading

Summary

Fixes #5293

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh linked an issue Jan 25, 2023 that may be closed by this pull request
Show link to exit mobile version on AMP pages even when mobile redirection is not enabled #5293
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2023 •
edited
Loading

Plugin builds for 2c7b186 are ready 🛎️!

@thelovekesh
Merge branch 'develop' into 5293-show-link-to-exit-mobile-version-on-…
e5addb9 
…amp-pages-even-when-mobile-redirection-is-not-enabled
@westonruter westonruter added this to the v2.4 milestone Jan 25, 2023
westonruter
westonruter requested changes Jan 25, 2023
View reviewed changes
tests/php/src/MobileRedirectionTest.php Show resolved Hide resolved
src/MobileRedirection.php Outdated Show resolved Hide resolved
src/MobileRedirection.php Outdated Show resolved Hide resolved
thelovekesh and others added 4 commits January 26, 2023 22:39
@thelovekesh @westonruter
Remove extra empty line
f976ff3 
Co-authored-by: Weston Ruter <westonruter@google.com>
@thelovekesh @westonruter
Update docblock with more precise defination
4b460b0 
Co-authored-by: Weston Ruter <westonruter@google.com>
@thelovekesh
Merge branch 'develop' into 5293-show-link-to-exit-mobile-version-on-…
36c65a6 
…amp-pages-even-when-mobile-redirection-is-not-enabled
@thelovekesh
Improve code quality by grouping conditionals in MobileRedirection se…
60c92a2 
…rvice
@thelovekesh thelovekesh self-assigned this Jan 26, 2023
@westonruter westonruter merged commit dfb5402 into develop Jan 26, 2023
@westonruter westonruter deleted the 5293-show-link-to-exit-mobile-version-on-amp-pages-even-when-mobile-redirection-is-not-enabled branch January 26, 2023 19:40
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

@thelovekesh thelovekesh

Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

Show link to exit mobile version on AMP pages even when mobile redirection is not enabled
2 participants
@thelovekesh @westonruter