Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guard to avoid fatal error in case logo height/width is zero #7429

Merged
merged 6 commits into from
Jan 30, 2023
Merged

Add guard to avoid fatal error in case logo height/width is zero #7429

merged 6 commits into from
Jan 30, 2023

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jan 27, 2023 •
edited
Loading

Summary

Fixes #7427

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2023 •
edited
Loading

Plugin builds for dea0db7 are ready 🛎️!

@thelovekesh thelovekesh self-assigned this Jan 27, 2023
@thelovekesh thelovekesh added this to the v2.4 milestone Jan 27, 2023
thelovekesh and others added 3 commits January 28, 2023 20:28
@thelovekesh @westonruter
Remove vague ternary operator
bc9bb9f 
Co-authored-by: Weston Ruter <westonruter@google.com>
@thelovekesh @westonruter
Update condition to bail early in case of image with zero width
f025b4b 
Co-authored-by: Weston Ruter <westonruter@google.com>
@thelovekesh
Update test cases to account zero as image width
dea0db7
@westonruter westonruter merged commit d465aeb into develop Jan 30, 2023
@westonruter westonruter deleted the fix/fatal-error-when-logo-height-is-zero branch January 30, 2023 17:52
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

@thelovekesh thelovekesh

Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

Fatal error (division by zero) in AMP_Core_Theme_Sanitizer::add_twentytwenty_custom_logo_fix()
2 participants
@thelovekesh @westonruter