Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react unique key prop error in <SiteScanNotice /> component #7448

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Fix react unique key prop error in <SiteScanNotice /> component #7448

merged 2 commits into from
Feb 3, 2023

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Feb 3, 2023 •
edited
Loading

Summary

Fix the react unique key prop error while rendering <SiteScanNotice /> in the plugin's admin screen which is usually triggered when someone activates a plugin.

Error:
image

Originally discovered in #7421 (comment) while working on #7421.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh self-assigned this Feb 3, 2023
@thelovekesh thelovekesh added the javascript Pull requests that update Javascript code label Feb 3, 2023
@thelovekesh thelovekesh added this to the v2.4 milestone Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023 •
edited
Loading

Plugin builds for 19df278 are ready 🛎️!

westonruter
westonruter requested changes Feb 3, 2023
View reviewed changes
assets/src/admin/site-scan-notice/notice.js Outdated Show resolved Hide resolved
assets/src/admin/site-scan-notice/notice.js Outdated Show resolved Hide resolved
@thelovekesh @westonruter
Update key props for elements in <AmpAdminNotice /> component
19df278 
Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
westonruter approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proactively addressing this!

@westonruter westonruter merged commit 4da32e6 into develop Feb 3, 2023
@westonruter westonruter deleted the fix/react-key-prop-error-in-admin-site-scan-notice branch February 3, 2023 17:32
@pavanpatil1
Copy link

QA passed ✅

Cross-checked the issue, Fix is working as expected. Now the console error after plugin compatibility scanning is not visible.

Before
image

After fix

consoleerror.mp4

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. javascript Pull requests that update Javascript code
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@thelovekesh @pavanpatil1 @westonruter