Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of amp_register_polyfills hook #7458

Merged
merged 13 commits into from
Feb 7, 2023
Merged

Fix usage of amp_register_polyfills hook #7458

merged 13 commits into from
Feb 7, 2023

Commits on Feb 7, 2023

  1. Update ValidationCounts service to register amp_register_polyfills … 

    …hook when screen is AMP options menu section
    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    077523c View commit details
    Browse the repository at this point in the history

  2. Update amp_register_polyfills to register Polyfills only on older W… 

    …P versions
    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    378522c View commit details
    Browse the repository at this point in the history

  3. Update is_options_menu() to is_dedicated_plugin_screen() in Validatio… 

    …nCounts class
    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    3c17ea9 View commit details
    Browse the repository at this point in the history

  4. Update docblock reference for amp_register_polyfills

    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    a931e7a View commit details
    Browse the repository at this point in the history

  5. Update webpack config to bundle @wordpress/dom-ready package with def… 

    …ault export library
    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5dba91a View commit details
    Browse the repository at this point in the history

  6. Remove amp_register_polyfills hook from ValidationCounts service

    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5343399 View commit details
    Browse the repository at this point in the history

  7. Remove amp customizer init if WP < 5.6

    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    ad16781 View commit details
    Browse the repository at this point in the history

  8. Remove amp_register_polyfills hook from AMP_Template_Customizer 

    - We are not using amp customizer on WP < 5.6, so polyfills are not needed. See: #7458 (comment)
    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    47c7934 View commit details
    Browse the repository at this point in the history

  9. Remove amp_register_polyfills hook from PairedBrowsing

    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    ec2974f View commit details
    Browse the repository at this point in the history

  10. Remove amp_register_polyfills hook assertions from PairedBrowsingTest

    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    8535112 View commit details
    Browse the repository at this point in the history

  11. Skip AMP customizer tests below WP 5.6

    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    e7500ab View commit details
    Browse the repository at this point in the history

  12. Update test skip message

    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    8fd04db View commit details
    Browse the repository at this point in the history

  13. Skip tests for PairedBrowsing if WP < 5

    @thelovekesh
    thelovekesh committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    56daefa View commit details
    Browse the repository at this point in the history