Fix docs generation command

[thelovekesh]

Summary

• Fix the issue due to the PHP patch version in version compares.
• Fix code issues that are causing PHP parser warnings.

Checklist

• My code is tested and passes existing tests.
• My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

[github-actions]

Plugin builds for 34bed2f are ready 🛎️!

• Download development build
• Download production build

Checksums

# Development build checksums
2c7c7265c5d94df4189aceae3d5819266b52e9f40fa9f8d8ba061844b4045eb6 *amp.zip

# Production build checksums
9509d19f94f65823523bc7bf3a5e596106610399cd0cdeaa17d709e1cbc8aeae *amp.zip

Warning

These builds are for testing purposes only and should not be used in production.

[thelovekesh]

A few warnings are coming up while docs generation from the PHP parser.

[03-Nov-2023 14:45:07 UTC] PHP Deprecated:  Invalid characters passed for attempted conversion, these have been ignored in /var/www/html/wp-content/plugins/amp/vendor/nikic/php-parser/lib/PhpParser/Node/Scalar/String_.php on line 93
Deprecated: Invalid characters passed for attempted conversion, these have been ignored in /var/www/html/wp-content/plugins/amp/vendor/nikic/php-parser/lib/PhpParser/Node/Scalar/String_.php on line 93

These are specifically due to:

x0B in

amp-wp/includes/sanitizers/class-amp-base-sanitizer.php

Line 880 in 66b8668

$style_string = trim( $style_string, " \t\n\r\0\x0B;" );

xEF, xBB and xBF in

amp-wp/includes/validation/class-amp-validation-manager.php

Line 2344 in 66b8668

while ( "\xEF\xBB\xBF" === substr( $response, 0, 3 ) ) {

This can also be due to an old PHP parser or can be some legitimate warnings.

[westonruter]

Could you add a comment to this explaining why it is ignored?

[thelovekesh]

Done in 34bed2f.