-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix local-env issue of missing xfs
user
#7813
Conversation
Plugin builds for 14bfb80 are ready 🛎️!
Checksums
Warning These builds are for testing purposes only and should not be used in production. |
# Check whether Node and NVM are installed | ||
. "$(dirname "$0")/install-node-nvm.sh" | ||
|
||
# Check whether Composer installed | ||
. "$(dirname "$0")/install-composer.sh" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the CI runners already have these tools pre-installed, and we configure NodeJS and Composer in the CI.
For local development, I doubt if this is being used given we already have wp-env setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's over my head, but LGTM!
E2E tests are running now - https://github.com/ampproject/amp-wp/actions/runs/9391104052/job/25862514993. I'll fix the failing tests in a different PR after merging dependabot PRs. |
E2E tests are running as expected in local env. QA Passed ✅. |
Summary
As it can be seen in the latest CI runs - https://github.com/ampproject/amp-wp/actions/runs/9389955987/job/25858689875, the
xfs
user is no longer available in the container powered by alpine Linux, and resulting in error like:This PR adds a custom Docker image which extends
wordpress
image and installs the wp-cli binary in the image itself.Checklist