Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mandatory parent special case for amp-subscriptions #7894

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

westonruter
Copy link
Member

See https://wordpress.org/support/topic/sanitizer-stripping-amp-subscriptions-encrypted-ciphertext/

The AMP spec uses the mandatory_parent key to refer to the tag name of the mandatory parent, except in one case for amp-subscriptions. This adds the special case.

@westonruter westonruter added the Bug Something isn't working label Oct 7, 2024
@westonruter westonruter added this to the v2.5.5 milestone Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Plugin builds for d8ab291 are ready 🛎️!

Checksums
# Development build checksums
dc7cb46d9407fdc877a7d3c436105f2d27b38609ee78f36b8e5399e5ff694cb9 *amp.zip

# Production build checksums
f7844cb7f9d905ea79e4548e28dced1f9878e3d84c81bc54c0d1cf17115fa709 *amp.zip

Warning

These builds are for testing purposes only and should not be used in production.

@westonruter
Copy link
Member Author

@thelovekesh We need this one included as well.

@westonruter westonruter merged commit a5a08dd into develop Nov 12, 2024
32 checks passed
@westonruter westonruter deleted the fix/subscriptions-section branch November 12, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants