Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 848: Allow theme support of canonical AMP #852

Merged
merged 6 commits into from
Jan 11, 2018
Merged

Issue 848: Allow theme support of canonical AMP #852

merged 6 commits into from
Jan 11, 2018

Commits on Jan 10, 2018

  1. Issue 848: Allow theme support of canonical AMP. 

    If themes register this with add_theme_support( 'amp' ),
the plugin will be in 'canonical mode.'
It won't display the 'rel' link,
And the theme will still use its own template.
But if any other argumnents are passed to add_theme_support( 'amp',
It will retain 'paired mode.'
Add unit tests for this new feature.
    Ryan Kienstra committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    995f0ce View commit details
    Browse the repository at this point in the history

  2. Bump 0.7-alpha

    @westonruter
    westonruter committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    9f8fb86 View commit details
    Browse the repository at this point in the history

  3. Allow amp_is_canonical() to be true if args are passed without templa… 

    …te_path
    @westonruter
    westonruter committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    b9e0925 View commit details
    Browse the repository at this point in the history

  4. Continue enqueueng edit post JS/CSS for when canonical mode functiona… 

    …lity is added
    @westonruter
    westonruter committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    4258e10 View commit details
    Browse the repository at this point in the history

  5. Improve position of canonical check in amp_maybe_add_actions() 

    Add test for amp_is_canonical() when arg other than template_path is added
    @westonruter
    westonruter committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    a1112c9 View commit details
    Browse the repository at this point in the history

  6. Issue 848 : Change 'AMP Settings' page with canonical AMP. 

    If the theme registers support for canonical AMP,
Check all of the post types in the 'AMP Settings' page.
And disable their <input>, as the theme will render the post types.
Also, change the description at the bottom.
And don't output the 'submit' button in canonical mode.
    Ryan Kienstra committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    4a1f621 View commit details
    Browse the repository at this point in the history