-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #864: Fix 'Video' widget for YouTube and Vimeo, simplify 'Gallery' solution #921
Commits on Jan 31, 2018
-
Issue #864: Address an issue in 'Video' widgets for YouTube and Vimeo.
These widgets have different logic in: WP_Widget_Media_Video::render() So override the value of wp_video_shortcode(), which renders these. Produce 'youtube' or 'vimeo' shortcodes. And this plugin's handlers will create <amp-youtube> and <amp-vimeo>. Another plugin is also free to override those shortcodes.
Ryan Kienstra committedJan 31, 2018 Configuration menu - View commit details
-
Copy full SHA for 218fc9d - Browse repository at this point
Copy the full SHA 218fc9dView commit details -
Issue #864: Only override video widget output if is_amp_endpoint().
Similarly to how the other widget overrides work. Also, adjust tests for this.
Ryan Kienstra committedJan 31, 2018 Configuration menu - View commit details
-
Copy full SHA for cb0f071 - Browse repository at this point
Copy the full SHA cb0f071View commit details -
Issue #864: Align equals signs in response to Travis error.
Ryan Kienstra committedJan 31, 2018 Configuration menu - View commit details
-
Copy full SHA for 6608df5 - Browse repository at this point
Copy the full SHA 6608df5View commit details -
Issue #864: Simply return the initial value, instead of ''.
This will allow another plugin to override this. Inspired by the Jetpack plugin's return of the initial value.
Ryan Kienstra committedJan 31, 2018 Configuration menu - View commit details
-
Copy full SHA for 76cf75f - Browse repository at this point
Copy the full SHA 76cf75fView commit details -
Issue #864: Remove the 'Gallery' widget subclass, in favor of a filter.
Thanks to Weston for mentioning how we could use 'post_gallery.' Using this removes the need to subclass that widget. The widget calls gallery_shortcode(), which has the filter: 'post_gallery' As Weston mentioned, Jetpack filters 'post_gallery'.
Ryan Kienstra committedJan 31, 2018 Configuration menu - View commit details
-
Copy full SHA for 9fab092 - Browse repository at this point
Copy the full SHA 9fab092View commit details
Commits on Feb 1, 2018
-
Issue #864: Move video override logic into embed handlers.
These are now in the embed classes. Also, create test classes for them.
Ryan Kienstra committedFeb 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 7c1f8fe - Browse repository at this point
Copy the full SHA 7c1f8feView commit details
Commits on Feb 2, 2018
-
Issue #864: Handle a 'fixed-height' issue with 'Video' widgets.
When they use 'Media Library' videos, they output <amp-video>. The AMP_Video_Sanitizer added a 'layout' value of 'fixed-height'. The height of 400px didn't look good, as the aspect ratio was wrong. Instead, make video widgets that use <amp-video> use layout=responsive. Detect this by checking that neight 'width' or 'height' are present. inject_video_max_width_style() removes these attributes for the widget. Otherwise, retain the previous logic.
Ryan Kienstra committedFeb 2, 2018 Configuration menu - View commit details
-
Copy full SHA for a330342 - Browse repository at this point
Copy the full SHA a330342View commit details
Commits on Feb 3, 2018
-
Revert "Issue #864: Handle a 'fixed-height' issue with 'Video' widgets."
This reverts commit a330342.
Ryan Kienstra committedFeb 3, 2018 Configuration menu - View commit details
-
Copy full SHA for 13b52da - Browse repository at this point
Copy the full SHA 13b52daView commit details -
Issue #864: Video widget fixes, including width and height.
Props @westonruter for the details of how to do this. Overrides the widget WP_Widget_Media_Video, in order to override the callback that strips the height and width. Also, add a style of 'width:100%' to the <amp-video>. This ensures that the widget doesn't overflow the container.
Ryan Kienstra committedFeb 3, 2018 Configuration menu - View commit details
-
Copy full SHA for ccba1c2 - Browse repository at this point
Copy the full SHA ccba1c2View commit details -
Issue #864: Fix an issue with the style placement, override 'Text.'
Override the 'Text' widget. Prevent the stripping of <video> width and height attributes. Also, move the addition of the 'style' attribute. Before, it wasn't added.
Ryan Kienstra committedFeb 3, 2018 Configuration menu - View commit details
-
Copy full SHA for 2e197d3 - Browse repository at this point
Copy the full SHA 2e197d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6e7c36 - Browse repository at this point
Copy the full SHA a6e7c36View commit details