-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run spec update to add support for amp-mathml, amp-riddle-quiz, amp-wistia-player, amp-byside-content, amp-bind-macro #943
Run spec update to add support for amp-mathml, amp-riddle-quiz, amp-wistia-player, amp-byside-content, amp-bind-macro #943
Conversation
@adamsilverstein does this successfully result in Could you add a test to For example: |
It should, I see the tags added to the generated file: https://github.com/Automattic/amp-wp/pull/943/files#diff-a761ebd1d4f764d95add0829d1378635R1325 I'll add some tests for this and other new amp-html tags I see added to the validation file. |
@westonruter I added tests for the new components I see in the pr that had matching docs at https://www.ampproject.org/docs/reference/components - namely amp-mathml, amp-riddle-quiz, amp-wistia-player, amp-byside-content & amp-bind-macro. I tried amp-facebook-page, but I think it is too new and not in production (https://github.com/ampproject/amphtml/blob/9673d3fe860d5d61eb9b1193fc2a49b59cdf094c/extensions/amp-facebook-page/amp-facebook-page.md), the test failed so I removed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thanks!
Includes updates to other elements and attributes in the validator spec.
Fixes #941