Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-analytics implementation issues on amproject.org #25

Closed
dspattison-google opened this issue Jan 29, 2016 · 4 comments
Closed

amp-analytics implementation issues on amproject.org #25

dspattison-google opened this issue Jan 29, 2016 · 4 comments
Assignees

Comments

@dspattison-google
Copy link

The hits being sent to google-analytics.com are missing the &cid parameter. This hits are being dropped and not tracked.

example page:
https://www.ampproject.org/docs/reference/extended/amp-analytics.html
using the debug server for https://www.google-analytics.com/debug/collect?v=1&_v=a0&aip=true&_s=&dl=https%3A%2F%2Fwww.ampproject.org%2Fdocs%2Freference%2Fextended%2Famp-analytics.html&dt=amp-analytics&sr=2560x1440&_utmht=14540832363216&jid=&cid=&tid=UA-67833617-1&t=pageview&_r=1&z=0.0456467

{
  "hitParsingResult": [ {
    "valid": false,
    "parserMessage": [ {
      "messageType": "INFO",
      "description": "IP Address from this hit was anonymized to 72.241.118.0.",
      "messageCode": "VALUE_MODIFIED"
    }, {
      "messageType": "INFO",
      "description": "A default value was used for the parameter 'cid'. Please see http://goo.gl/a8d4RP#cid for details.",
      "messageCode": "DEFAULT_VALUE_USED",
      "parameter": "cid"
    }, {
      "messageType": "ERROR",
      "description": "A value is required for parameter 'cid'. Please see http://goo.gl/a8d4RP#cid for details.",
      "messageCode": "VALUE_REQUIRED",
      "parameter": "cid"
    } ],
    "hit": "/debug/collect?v=1\u0026_v=a0\u0026aip=true\u0026_s=\u0026dl=https%3A%2F%2Fwww.ampproject.org%2Fdocs%2Freference%2Fextended%2Famp-analytics.html\u0026dt=amp-analytics\u0026sr=2560x1440\u0026_utmht=1454083780209\u0026jid=\u0026cid=\u0026tid=UA-67833617-1\u0026t=pageview\u0026_r=1\u0026z=0.07820693154899105"
  } ],
  "parserMessage": [ {
    "messageType": "INFO",
    "description": "Found 1 hit in the request."
  } ]
}
@avimehta
Copy link
Contributor

The fix should be live with next release.

@avimehta
Copy link
Contributor

avimehta commented Feb 2, 2016

this is fixed now..

@rudygalfi
Copy link
Collaborator

Fixed via ampproject/amphtml#1627.

@Meggin
Copy link
Contributor

Meggin commented Apr 26, 2016

Closing as this works.

@Meggin Meggin closed this as completed Apr 26, 2016
ghost pushed a commit that referenced this issue Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants