Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bento docs for amp-date-display links to missing stylesheet #5901

Closed
westonruter opened this issue May 25, 2021 · 2 comments · Fixed by ampproject/amphtml#34861
Closed

Bento docs for amp-date-display links to missing stylesheet #5901

westonruter opened this issue May 25, 2021 · 2 comments · Fixed by ampproject/amphtml#34861

Comments

@westonruter
Copy link
Member

🐛 Bug Report

Current behavior

On the docs for amp-date-display v1.0, the Bento option shows this HTML to copy:

<script async custom-element="amp-date-display" src="https://cdn.ampproject.org/v0/amp-date-display-1.0.js"></script>
<link rel="stylesheet" href="https://cdn.ampproject.org/v0/amp-date-display-1.0.css">

Problem: https://cdn.ampproject.org/v0/amp-date-display-1.0.css is a 404.

This is not a problem for amp-base-carousel v1.0 where it shows:

<script async custom-element="amp-base-carousel" src="https://cdn.ampproject.org/v0/amp-base-carousel-1.0.js"></script>
<link rel="stylesheet" href="https://cdn.ampproject.org/v0/amp-base-carousel-1.0.css">

And the stylesheet URL is OK: https://cdn.ampproject.org/v0/amp-base-carousel-1.0.css

Expected behavior/code

Bento stylesheet link should not 404.

@sebastianbenz
Copy link
Collaborator

@caroqliu do you know why amp-date-display hasn't got a CSS file?

@caroqliu
Copy link
Collaborator

@caroqliu do you know why amp-date-display hasn't got a CSS file?

No good reason, I'll add now. It also appears to be missing for amp-date-countdown and amp-timeago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants