Bento: Ensure all Bento components have a CSS file #34861
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.1
do not need a CSS file, the1.0
serves the purpose of providing pre-upgrade styles for layout stability, to be included as<link>
tag on non-AMP pages.amp-render
which to my knowledge will not be usable on non-AMP documents.hasCss
for these new components which only have "pre-upgrade" styles -- bundling them with AMP components for use on AMP pages would be redundant to the pre-upgrade document stability styles provided by AMP's boilerplate. (In fact, a separate PR should removehasCss: true
from applicable Bento components that currently have it enabled.)amp-date-display
links to missing stylesheet amp.dev#5901