Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bento amp-lightbox (v1.0) example broken #6071

Closed
westonruter opened this issue Jul 26, 2021 · 1 comment · Fixed by ampproject/amphtml#35490
Closed

Bento amp-lightbox (v1.0) example broken #6071

westonruter opened this issue Jul 26, 2021 · 1 comment · Fixed by ampproject/amphtml#35490
Assignees
@lluerich
Labels
Category: Documentation Category: Examples Status: Pending Triage Type: Bug

Comments

@westonruter
Copy link
Member

westonruter commented Jul 26, 2021 •
edited
Loading

🐛 Bug Report

The Bento amp-lightbox example is broken at https://amp.dev/documentation/components/amp-lightbox-v1.0/?format=websites

Clicking the button to open the lightbox does nothing. There are errors in the console:

image

From https://preview.amp.dev/documentation/components/amp-lightbox-v1.0.example.1.html
@lluerich lluerich self-assigned this Jul 27, 2021
@lluerich
Copy link
Collaborator

lluerich commented Aug 2, 2021

layout="nodisplay" on amp-lightbox is missing in the example.

@lluerich lluerich mentioned this issue Aug 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lluerich lluerich

Labels
Category: Documentation Category: Examples Status: Pending Triage Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 amp-list: add missing layout attribute to fix amp.dev example
2 participants
@westonruter @lluerich