Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 amp-list: add missing layout attribute to fix amp.dev example #35490

Merged
merged 1 commit into from
Aug 3, 2021
Merged

🐛 amp-list: add missing layout attribute to fix amp.dev example #35490

merged 1 commit into from
Aug 3, 2021

Conversation

lluerich
Copy link
Contributor

@lluerich lluerich commented Aug 2, 2021

This adds the missing layout="nodisplay" attribute to the amp-lightbox code sample.
Fixes ampproject/amp.dev#6071.

/cc @sebastianbenz @matthiasrohmer

Copy link
Contributor

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samouri samouri enabled auto-merge (squash) August 2, 2021 17:57
@lluerich lluerich changed the title 🐛 amp-list: add missing layout attribute to fix amp.dev example 🐛 amp-list: add missing layout attribute to fix amp.dev example Aug 3, 2021
@sebastianbenz
Copy link
Contributor

@samouri seems like bundle-size is stuck, is there a way to restart?

@samouri
Copy link
Member

samouri commented Aug 3, 2021

Yep! Thanks for the ping @sebastianbenz. There was a bundle size bot bug re. non-js-code affecting changes. The fix was just merged last evening (#35492).

I've rebased and force pushed 🤞

@samouri samouri merged commit 4c5f740 into ampproject:main Aug 3, 2021
westonruter added a commit to westonruter/amphtml that referenced this pull request Aug 3, 2021
…tok-validation

* 'main' of github.com:ampproject/amphtml: (72 commits)
  build: run amp lint --fix to address import order of jixie (ampproject#35513)
  ✨ [amp-analytics] Add Custom Browser Event Tracker (ampproject#35193)
  babel: teach amp mode transformer about #core/mode (ampproject#35477)
  🚮 Remove experiment `amp-consent-granular-consent` (ampproject#35508)
  ♻️ Enable auto-sorting+grouping within src/ and 3p/ (ampproject#35454)
  🐛  [amp-render] fix root-element stripping from amp-render with amp-bind (ampproject#35449)
  ✅ [Story interactive] Add Example Story for Detailed Results Component (ampproject#35450)
  🐛 Fix error on bento example (ampproject#35490)
  🐛 amp-story-grid-layer: Fix AMP invalidation error in documentation (ampproject#35503)
  🐛 Fix code formatting (ampproject#35499)
  ✅ buildDom: add tests for amp-fit-text and amp-layout (ampproject#35494)
  ♻️ Remove unused imports (ampproject#35435)
  ✨ amp-connatix-player: iframe domain based on a property (ampproject#35179)
  Updated document with use cases of remote config (ampproject#35496)
  AMP.goBack: update documentation (ampproject#29290)
  🏗 Allow the bundle-size job to run even if the builds were skipped (ampproject#35492)
  build-system: improve terser/esbuild integration (ampproject#35466)
  🧪 [Story performance] Disable animations on first page to 50% (ampproject#35476)
  📖 [Amp story] [Page attachments] Amp.dev Docs for New Page Attachment Features ampproject#34883 (ampproject#35338)
  🚀 [Story interactive] Rewrite Image URL to Cached URL for Image Quizzes and Polls (ampproject#35375)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bento amp-lightbox (v1.0) example broken
4 participants