babel: teach amp mode transformer about #core/mode #35477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @erwinmombay, @jridgewell! These files were changed: |
rcebulko
reviewed
Aug 2, 2021
build-system/babel-plugins/babel-plugin-amp-mode-transformer/index.js
Outdated
Show resolved
Hide resolved
rcebulko
approved these changes
Aug 2, 2021
jridgewell
requested changes
Aug 3, 2021
|
|
||
| const {INTERNAL_RUNTIME_VERSION: version} = this.opts; | ||
| const {callee} = path.node; | ||
| if ( |
There was a problem hiding this comment.
Really, these should be updated to use referencesImport: https://astexplorer.net/#/gist/027ec54f10db0c8b67f30271097ff792/45deb3c152ce246ee14f43c11c9a698b4148d295
There was a problem hiding this comment.
Does that work for getMode too? It uses relative imports
There was a problem hiding this comment.
You'll need to resolve the relative path for each file, but otherwise yes.
build-system/babel-plugins/babel-plugin-amp-mode-transformer/index.js
Outdated
Show resolved
Hide resolved
samouri
force-pushed
the
babel-mode-xform
branch
from
39f568a to
87504ec
Compare
jridgewell
approved these changes
Aug 3, 2021
samouri
force-pushed
the
babel-mode-xform
branch
from
87504ec to
52dd3cf
Compare
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Aug 3, 2021
…tok-validation * 'main' of github.com:ampproject/amphtml: (72 commits) build: run amp lint --fix to address import order of jixie (ampproject#35513) ✨ [amp-analytics] Add Custom Browser Event Tracker (ampproject#35193) babel: teach amp mode transformer about #core/mode (ampproject#35477) 🚮 Remove experiment `amp-consent-granular-consent` (ampproject#35508) ♻️ Enable auto-sorting+grouping within src/ and 3p/ (ampproject#35454) 🐛 [amp-render] fix root-element stripping from amp-render with amp-bind (ampproject#35449) ✅ [Story interactive] Add Example Story for Detailed Results Component (ampproject#35450) 🐛 Fix error on bento example (ampproject#35490) 🐛 amp-story-grid-layer: Fix AMP invalidation error in documentation (ampproject#35503) 🐛 Fix code formatting (ampproject#35499) ✅ buildDom: add tests for amp-fit-text and amp-layout (ampproject#35494) ♻️ Remove unused imports (ampproject#35435) ✨ amp-connatix-player: iframe domain based on a property (ampproject#35179) Updated document with use cases of remote config (ampproject#35496) AMP.goBack: update documentation (ampproject#29290) 🏗 Allow the bundle-size job to run even if the builds were skipped (ampproject#35492) build-system: improve terser/esbuild integration (ampproject#35466) 🧪 [Story performance] Disable animations on first page to 50% (ampproject#35476) 📖 [Amp story] [Page attachments] Amp.dev Docs for New Page Attachment Features ampproject#34883 (ampproject#35338) 🚀 [Story interactive] Rewrite Image URL to Cached URL for Image Quizzes and Polls (ampproject#35375) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Blocks #35298
Teaches amp mode transformer how to inline
mode.version().cc @ampproject/wg-performance