Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change toolbox to use ampjs version #6793

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Change toolbox to use ampjs version #6793

merged 1 commit into from
Apr 10, 2024

Conversation

powerivq
Copy link
Collaborator

@powerivq powerivq commented Apr 9, 2024

Currently the page generated use Google AMP CDN. This PR changes that.

@powerivq powerivq requested a review from erwinmombay April 9, 2024 21:10
@powerivq powerivq requested a review from danielrozenberg April 9, 2024 21:13
danielrozenberg
danielrozenberg approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@danielrozenberg danielrozenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create an issue to revert this once we get a more permanent solution?

@powerivq powerivq merged commit 0392ae0 into main Apr 10, 2024
4 checks passed
@powerivq powerivq deleted the toolbox-dep branch April 10, 2024 17:28
@powerivq powerivq mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrozenberg danielrozenberg danielrozenberg approved these changes

@erwinmombay erwinmombay erwinmombay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@powerivq @erwinmombay @danielrozenberg