📦 Update build-system devDependencies (#40066)

* 📦 Update build-system devDependencies

* Override types

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev>

build-system/tasks/e2e/package.json

@@ -5,10 +5,10 @@
   "description": "amp e2e",
   "devDependencies": {
     "@babel/register": "7.24.6",
-    "@types/selenium-webdriver": "4.1.22",
+    "@types/selenium-webdriver": "4.1.23",
     "babel-regenerator-runtime": "6.5.0",
     "chromedriver": "119.0.1",
     "geckodriver": "4.4.1",
-    "selenium-webdriver": "4.21.0"
+    "selenium-webdriver": "4.22.0"
   }
 }

build-system/tasks/e2e/selenium-webdriver-controller.js

@@ -65,11 +65,13 @@ async function waitFor(driver, valueFn, condition, opt_mutate) {
     return Boolean(condition(value));
   };
 
+  /* TODO: fix incorrect typing. */
+  /** @type {any} */
   const result = await driver.wait(
     expectCondition(valueFn, conditionValue, opt_mutate)
   );
 
-  return result.value; // Unbox the value.
+  return result;
 }
 
 class SeleniumWebDriverController {
@@ -156,7 +158,11 @@ class SeleniumWebDriverController {
         throw e;
       }
     });
-    const webElements = await this.driver.wait(condition, ELEMENT_WAIT_TIMEOUT);
+    /* TODO: fix incorrect typing. */
+    /** @type {WebElement[]} */
+    const webElements = /** @type {?} */ (
+      await this.driver.wait(condition, ELEMENT_WAIT_TIMEOUT)
+    );
     return webElements.map((webElement) => new ElementHandle(webElement));
   }
 
@@ -192,19 +198,23 @@ class SeleniumWebDriverController {
   async findElementsXPath(xpath) {
     await this.maybeInstallXpath_();
     const label = 'for at least one element to be located ' + xpath;
-    const webElements = await this.driver.wait(
-      new Condition(label, async () => {
-        const root = await this.getRoot_();
-        const results = await this.evaluate(
-          (xpath, root) => {
-            return window.queryXpath(xpath, root);
-          },
-          xpath,
-          root
-        );
-        return results;
-      }),
-      ELEMENT_WAIT_TIMEOUT
+    /* TODO: fix incorrect typing. */
+    /** @type {WebElement[]} */
+    const webElements = /** @type {?} */ (
+      await this.driver.wait(
+        new Condition(label, async () => {
+          const root = await this.getRoot_();
+          const results = await this.evaluate(
+            (xpath, root) => {
+              return window.queryXpath(xpath, root);
+            },
+            xpath,
+            root
+          );
+          return results;
+        }),
+        ELEMENT_WAIT_TIMEOUT
+      )
     );
     return webElements.map((webElement) => new ElementHandle(webElement));
   }
@@ -295,7 +305,7 @@ class SeleniumWebDriverController {
    */
   pasteFromClipboard() {
     return this.driver
-      .actions()
+      .actions({async: false, bridge: undefined})
       .keyDown(SeleniumKey.SHIFT)
       .keyDown(SeleniumKey.INSERT)
       .keyUp(SeleniumKey.SHIFT)