Skip to content

Commit

Permalink
revert change validator-amp-ad-protoascii
Browse files Browse the repository at this point in the history
  • Loading branch information
tiendt committed Aug 4, 2017
1 parent c7ffc82 commit 48151ac
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions extensions/amp-ad/validator-amp-ad.protoascii
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
# Historically, amp-ad/amp-embed javascript were embedded into the main
# runtime (v0.js), so there are many pages that do not include the amp-ad
# extension. We want to warn for these.
# AMP-USER_ERROR_EMBED_SENTINEL requires the amp-ad extension, not amp-embed.
# Including the amp-ad extension, but not an AMP-AD/AMP-USER_ERROR_EMBED_SENTINEL tag should only
# AMP-EMBED requires the amp-ad extension, not amp-embed.
# Including the amp-ad extension, but not an AMP-AD/AMP-EMBED tag should only
# produce a warning.
#
# To implement this, we mark the tags as requires_extension amp-ad, but the
Expand Down Expand Up @@ -120,7 +120,7 @@ tags: { # <amp-ad data-multi-size>
}
tags: { # <amp-embed>
html_format: AMP
tag_name: "AMP-USER_ERROR_EMBED_SENTINEL"
tag_name: "AMP-EMBED"
requires_extension: "amp-ad" # See note at top of file
also_requires_tag_warning: "amp-ad extension .js script"
disallowed_ancestor: "AMP-APP-BANNER"
Expand Down Expand Up @@ -149,7 +149,7 @@ tags: { # <amp-embed>
}
tags: { # <amp-embed data-multi-size>
html_format: AMP
tag_name: "AMP-USER_ERROR_EMBED_SENTINEL"
tag_name: "AMP-EMBED"
spec_name: "amp-embed with data-multi-size attribute"
requires_extension: "amp-ad" # See note at top of file
also_requires_tag_warning: "amp-ad extension .js script"
Expand Down

0 comments on commit 48151ac

Please sign in to comment.