✨ New feature (I2I: Sending data-json to premiumads API for amp-auto-…

…ads #40041 ) (#40042) * LOND-3031 sendind data-json to api * LOND-3031 fixing pr-check lint * LOND-3031 removing unnecessary vertical margin * LOND-3031 fixing test * LOND-3031 testing * LOND-3031 removing comment
ampproject · Aug 20, 2024 · 51c6913 · 51c6913
1 parent 40487a9
commit 51c6913
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/extensions/amp-auto-ads/0.1/attributes.js b/extensions/amp-auto-ads/0.1/attributes.js
@@ -15,6 +15,7 @@ const NON_DATA_ATTRIBUTE_ALLOWLIST = {
   'height': true,
   'width': true,
   'sticky': true,
+  'json': true,
 };
 
 /**

diff --git a/extensions/amp-auto-ads/0.1/premiumads-network-config.js b/extensions/amp-auto-ads/0.1/premiumads-network-config.js
@@ -31,7 +31,11 @@ export class PremiumadsNetworkConfig {
   getConfigUrl() {
     const data = this.autoAmpAdsElement_.dataset;
     const host = data.host || 'https://tags.premiumads.com.br';
-    return buildUrl(`${host}/autoads/${data.publisher}`, {}, 4096);
+    return buildUrl(
+      `${host}/autoads/${data.publisher}`,
+      data.json ? {'json': data.json} : {},
+      4096
+    );
   }
 
   /** @override */
@@ -49,7 +53,7 @@ export class PremiumadsNetworkConfig {
       'layout': data.layout || Layout_Enum.FIXED,
       'style':
         data['style'] ||
-        'margin: 15px auto; position: relative !important; display: block !important;',
+        'margin: 0 auto; position: relative !important; display: block !important;',
     };
   }
 

diff --git a/extensions/amp-auto-ads/0.1/test/test-premiumads-network-config.js b/extensions/amp-auto-ads/0.1/test/test-premiumads-network-config.js
@@ -76,7 +76,7 @@ describes.realWin(
           'json': '',
           'layout': Layout_Enum.FIXED,
           'style':
-            'margin: 15px auto; position: relative !important; display: block !important;',
+            'margin: 0 auto; position: relative !important; display: block !important;',
         });
       });