🚮 remove yahoo ad component as it is no longer in use nor working (#4…

…0011) * remove yahoo ad component as it is no longer in use nor working * fix: removed missed yahoo.js file * fix: cleanup all references to yahoo ad component
ampproject · Aug 28, 2024 · 712895a · 712895a
1 parent 49f98ac
commit 712895a
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 135 deletions.
diff --git a/3p/integration.js b/3p/integration.js
@@ -287,7 +287,6 @@ import {wisteria} from '#ads/vendors/wisteria';
 import {wpmedia} from '#ads/vendors/wpmedia';
 import {wunderkind} from '#ads/vendors/wunderkind';
 import {xlift} from '#ads/vendors/xlift';
-import {yahoo} from '#ads/vendors/yahoo';
 import {yahoofedads} from '#ads/vendors/yahoofedads';
 import {yahoojp} from '#ads/vendors/yahoojp';
 import {yahoonativeads} from '#ads/vendors/yahoonativeads';
@@ -583,7 +582,6 @@ register('wisteria', wisteria);
 register('wunderkind', wunderkind);
 register('wpmedia', wpmedia);
 register('xlift', xlift);
-register('yahoo', yahoo);
 register('yahoofedads', yahoofedads);
 register('yahoojp', yahoojp);
 register('yahoonativeads', yahoonativeads);

diff --git a/3p/vendors/yahoo.js b/3p/vendors/yahoo.js
diff --git a/ads/_config.js b/ads/_config.js
@@ -1487,11 +1487,6 @@ const adConfig = jsonConfiguration({
     renderStartImplemented: true,
   },
 
-  'yahoo': {
-    prefetch: 'https://s.yimg.com/aaq/ampad/display.js',
-    preconnect: 'https://us.adserver.yahoo.com',
-  },
-
   'yahoofedads': {
     renderStartImplemented: true,
   },

diff --git a/ads/vendors/yahoo.js b/ads/vendors/yahoo.js
diff --git a/ads/vendors/yahoo.md b/ads/vendors/yahoo.md
diff --git a/examples/amp-ad/ads.amp.esm.html b/examples/amp-ad/ads.amp.esm.html
@@ -290,7 +290,6 @@
         <option>whopainfeed</option>
         <option>wpmedia</option>
         <option>xlift</option>
-        <option>yahoo</option>
         <option>yahoojp</option>
         <option>yahoonativeads</option>
         <option>yandex</option>
@@ -2353,14 +2352,6 @@ <h2>Xlift native ad</h2>
       data-mediaid="mamastar">
   </amp-ad>
 
-  <h2>Yahoo Display</h2>
-  <amp-ad width="316" height="264"
-      type="yahoo"
-      data-sid="954014446"
-      data-site="news"
-      data-sa='{"LREC":"300x250","secure":"true","content":"no_expandable;"}'>
-  </amp-ad>
-
   <h2>Yahoo Native Ads</h2>
   <amp-embed width="320" height="320"
     type="yahoonativeads"

diff --git a/examples/amp-ad/ads.amp.html b/examples/amp-ad/ads.amp.html
@@ -437,7 +437,6 @@
         <option>whopainfeed</option>
         <option>wpmedia</option>
         <option>xlift</option>
-        <option>yahoo</option>
         <option>yahoofedads</option>
         <option>yahoojp</option>
         <option>yahoonativeads</option>
@@ -1997,11 +1996,6 @@ <h2>Xlift native ad</h2>
   <amp-ad width="300" height="300" type="xlift" data-mediaid="mamastar">
   </amp-ad>
 
-  <h2>Yahoo Display</h2>
-  <amp-ad width="316" height="264" type="yahoo" data-sid="954014446" data-site="news"
-    data-sa='{"LREC":"300x250","secure":"true","content":"no_expandable;"}'>
-  </amp-ad>
-
   <h2>Yahoo Native-Display Ads Federation</h2>
   <amp-embed width="320" height="320" type="yahoofedads" layout="responsive" data-site="finance" data-region="US"
     data-lang="en-US" data-ad-unit="pencil"

diff --git a/extensions/amp-ad/amp-ad.md b/extensions/amp-ad/amp-ad.md
@@ -507,7 +507,6 @@ See [amp-ad rules](validator-amp-ad.protoascii) in the AMP validator specificati
 -   [WPMedia](../../ads/vendors/wpmedia.md)
 -   [Wunderkind](../../ads/vendors/wunderkind.md)
 -   [Xlift](../../ads/vendors/xlift.md)
--   [Yahoo](../../ads/vendors/yahoo.md)
 -   [YahooJP](../../ads/vendors/yahoojp.md)
 -   [Yandex](../../ads/vendors/yandex.md)
 -   [Yektanet](../../ads/vendors/yektanet.md)

diff --git a/validator/testdata/feature_tests/ads.html b/validator/testdata/feature_tests/ads.html
@@ -178,7 +178,6 @@
         <option>weborama</option>
         <option>widespace</option>
         <option>xlift</option>
-        <option>yahoo</option>
         <option>yahoojp</option>
         <option>yandex</option>
         <option>yieldbot</option>
@@ -1267,14 +1266,6 @@ <h2>Xlift native ad</h2>
       data-mediaid="mamastar">
   </amp-ad>
 
-  <h2>Yahoo Display</h2>
-  <amp-ad width="316" height="264"
-      type="yahoo"
-      data-sid="954014446"
-      data-site="news"
-      data-sa='{"LREC":"300x250","secure":"true","content":"no_expandable;"}'>
-  </amp-ad>
-
   <h2>YahooJP YDN</h2>
   <amp-ad width="300" height="250"
       type="yahoojp"

diff --git a/validator/testdata/feature_tests/ads.out b/validator/testdata/feature_tests/ads.out
@@ -179,7 +179,6 @@ PASS
 |          <option>weborama</option>
 |          <option>widespace</option>
 |          <option>xlift</option>
-|          <option>yahoo</option>
 |          <option>yahoojp</option>
 |          <option>yandex</option>
 |          <option>yieldbot</option>
@@ -1268,14 +1267,6 @@ PASS
 |        data-mediaid="mamastar">
 |    </amp-ad>
 |
-|    <h2>Yahoo Display</h2>
-|    <amp-ad width="316" height="264"
-|        type="yahoo"
-|        data-sid="954014446"
-|        data-site="news"
-|        data-sa='{"LREC":"300x250","secure":"true","content":"no_expandable;"}'>
-|    </amp-ad>
-|
 |    <h2>YahooJP YDN</h2>
 |    <amp-ad width="300" height="250"
 |        type="yahoojp"
@@ -1352,4 +1343,4 @@ PASS
 |        data-frame-id="_bda46cf5ac">
 |    </amp-ad>
 |  </body>
-|  </html>
+|  </html>