Updates

ampproject · May 14, 2018 · 75ec660 · 75ec660
1 parent f50a8dc
commit 75ec660
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 14 deletions.
diff --git a/build-system/eslint-rules/prefer-destructuring.js b/build-system/eslint-rules/prefer-destructuring.js
@@ -83,7 +83,7 @@ module.exports = {
           const ids = [];
 
           names.forEach(name => ids.push(name));
-          const replacement = `{${ids.join(', ')}} = ${base} `;
+          const replacement = `{${ids.join(', ')}} = ${base}`;
           fixes.push(fixer.replaceText(node, replacement));
 
           declarations.forEach(declaration => {

diff --git a/extensions/amp-access/0.1/iframe-api/messenger.js b/extensions/amp-access/0.1/iframe-api/messenger.js
@@ -153,8 +153,7 @@ export class Messenger {
   sendCommandRsvp(cmd, opt_payload) {
     const rsvpId = String(++this.requestId_);
     const deferred = new Deferred();
-    const promise = deferred.promise;
-    const resolver = deferred.resolve;
+    const {promise, resolve: resolver} = deferred;
 
     this.waiting_[rsvpId] = {
       promise,

diff --git a/extensions/amp-ad/0.1/amp-ad-xorigin-iframe-handler.js b/extensions/amp-ad/0.1/amp-ad-xorigin-iframe-handler.js
@@ -184,12 +184,14 @@ export class AmpAdXOriginIframeHandler {
     }
 
     // Calculate render-start and no-content signals.
-    const renderDeferred = new Deferred();
-    const renderStartPromise = renderDeferred.promise;
-    const renderStartResolve = renderDeferred.resolve;
-    const noContentDeferred = new Deferred();
-    const noContentPromise = noContentDeferred.promise;
-    const noContentResolve = noContentDeferred.resolve;
+    const {
+      promise: renderStartPromise,
+      resolve: renderStartResolve,
+    } = new Deferred();
+    const {
+      promise: noContentPromise,
+      resolve: noContentResolve
+    } = new Deferred();
 
     if (this.baseInstance_.config &&
             this.baseInstance_.config.renderStartImplemented) {

diff --git a/extensions/amp-list/0.1/amp-list.js b/extensions/amp-list/0.1/amp-list.js
@@ -243,9 +243,7 @@ export class AmpList extends AMP.BaseElement {
    */
   scheduleRender_(items) {
     const deferred = new Deferred();
-    const promise = deferred.promise;
-    const resolver = deferred.resolve;
-    const rejecter = deferred.reject;
+    const {promise, resolve: resolver, reject: rejecter} = deferred;
 
     // If there's nothing currently being rendered, schedule a render pass.
     if (!this.renderItems_) {

diff --git a/extensions/amp-user-notification/0.1/amp-user-notification.js b/extensions/amp-user-notification/0.1/amp-user-notification.js
@@ -491,8 +491,7 @@ export class UserNotificationManager {
     }
 
     const deferred = new Deferred();
-    const promise = deferred.promise;
-    const resolve = deferred.resolve;
+    const {promise, resolve} = deferred;
 
     return this.deferRegistry_[id] = {promise, resolve};
   }