init

ampproject · Apr 28, 2021 · a45e333 · a45e333
1 parent b25b7fa
commit a45e333
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 104 deletions.
diff --git a/extensions/amp-consent/0.1/consent-state-manager.js b/extensions/amp-consent/0.1/consent-state-manager.js
@@ -31,15 +31,12 @@ import {
 import {Deferred} from '../../../src/core/data-structures/promise';
 import {Services} from '../../../src/services';
 import {assertHttpsUrl} from '../../../src/url';
-import {dev, devAssert, user} from '../../../src/log';
-import {dict, hasOwn} from '../../../src/core/types/object';
+import {dev, devAssert} from '../../../src/log';
 import {expandConsentEndpointUrl, getConsentCID} from './consent-config';
+import {hasOwn} from '../../../src/core/types/object';
 
 const TAG = 'CONSENT-STATE-MANAGER';
 
-/** @visibleForTesting */
-export const CONSENT_STORAGE_MAX = 1200;
-
 export class ConsentStateManager {
  /**
  * Creates an instance of ConsentStateManager.
@@ -447,39 +444,6 @@ export class ConsentInstance {
  return;
  }
 
- // Check size
- const size = JSON.stringify(
- dict({
- [this.storageKey_]: value,
- })
- ).length;
-
- if (size > CONSENT_STORAGE_MAX) {
- // Size restriction only applies to documents servered from a viewer
- // that implements the storage API.
- const usesViewerStorage = storage.isViewerStorage();
- if (usesViewerStorage) {
- // 1200 * 4/3 (base64) = 1600 bytes
- user().error(
- TAG,
- 'Cannot store consent information which length exceeds %s. ' +
- 'Previous stored consentInfo will be cleared',
- CONSENT_STORAGE_MAX
- );
- // If new consentInfo value cannot be stored, need to remove previous
- // value
- storage.remove(this.storageKey_);
- // TODO: Good to have a way to inform CMP service in this case
- return;
- }
- user().info(
- TAG,
- 'Current consent information length exceeds %s ' +
- 'and will not be stored when the page is served ' +
- 'from a viewer that supports the Local Storage API.',
- CONSENT_STORAGE_MAX
- );
- }
  this.savedConsentInfo_ = consentInfo;
  storage.setNonBoolean(this.storageKey_, value);
  this.sendUpdateHrefRequest_(consentInfo);

diff --git a/extensions/amp-consent/0.1/test/test-consent-state-manager.js b/extensions/amp-consent/0.1/test/test-consent-state-manager.js
@@ -20,12 +20,8 @@ import {
  constructConsentInfo,
  constructMetadata,
 } from '../consent-info';
-import {
- CONSENT_STORAGE_MAX,
- ConsentInstance,
- ConsentStateManager,
-} from '../consent-state-manager';
 import {CONSENT_STRING_TYPE} from '../../../../src/core/constants/consent-state';
+import {ConsentInstance, ConsentStateManager} from '../consent-state-manager';
 import {Services} from '../../../../src/services';
 import {dev} from '../../../../src/log';
 import {macroTask} from '../../../../testing/yield';
@@ -194,35 +190,6 @@ describes.realWin('ConsentStateManager', {amp: 1}, (env) => {
  )
  );
  });
-
- it('update consent string that exceeds max size', async () => {
- expectAsyncConsoleError(/Cannot store consent information/);
- manager.registerConsentInstance('test', {});
- let testStr = 'a';
- // Reserve 26 chars to metadata size `"m":{"cst":1,"ac":"12345"}`
- // Reserve 36 chars to the storage key, `''` and `{}`
- // Leaves CONSENT_STORAGE_MAX - 62 chars to consent string
- for (let i = 0; i < CONSENT_STORAGE_MAX - 62; i++) {
- testStr += 'a';
- }
- manager.updateConsentInstancePurposes({
- 'purpose-abc': PURPOSE_CONSENT_STATE.ACCEPTED,
- });
- manager.updateConsentInstanceState(
- CONSENT_ITEM_STATE.ACCEPTED,
- testStr,
- constructMetadata(CONSENT_STRING_TYPE.TCF_V1, '12345')
- );
- const value = await manager.getConsentInstanceInfo();
- expect(value).to.deep.equal(
- constructConsentInfo(
- CONSENT_ITEM_STATE.ACCEPTED,
- testStr,
- constructMetadata(CONSENT_STRING_TYPE.TCF_V1, '12345'),
- {'purpose-abc': PURPOSE_CONSENT_STATE.ACCEPTED}
- )
- );
- });
  });
 
  describe('onConsentStateChange', () => {
@@ -497,38 +464,6 @@ describes.realWin('ConsentStateManager', {amp: 1}, (env) => {
  expect(storageSetSpy).to.not.be.called;
  expect(storageRemoveSpy).to.be.calledOnce;
  });
-
- it('remove consentInfo when consentStr length exceeds', function* () {
- expectAsyncConsoleError(/Cannot store consent information/);
- let testStr = 'a';
- // Reserve 26 chars to metadata size `"m":{"cst":1,"ac":"12345"}`
- // Reserve 36 chars to the storage key, `''` and `{}`
- // Leaves CONSENT_STORAGE_MAX - 62 chars to consent string
- for (let i = 0; i < CONSENT_STORAGE_MAX - 62; i++) {
- testStr += 'a';
- }
- instance.update(
- CONSENT_ITEM_STATE.ACCEPTED,
- testStr,
- undefined,
- constructMetadata(CONSENT_STRING_TYPE.TCF_V1, '12345')
- );
- yield macroTask();
- expect(storageSetSpy).to.not.be.called;
- expect(storageRemoveSpy).to.be.calledOnce;
- });
-
- it('allows large consentInfo when not using viewer storage API', async () => {
- usesViewer = false;
- let testStr = 'a';
- for (let i = 0; i < CONSENT_STORAGE_MAX - 62; i++) {
- testStr += 'a';
- }
- instance.update(CONSENT_ITEM_STATE.ACCEPTED, testStr);
- await macroTask();
- expect(storageSetSpy).to.be.calledOnce;
- expect(storageRemoveSpy).to.not.be.called;
- });
  });
 
  describe('should override stored value correctly', () => {