Fix many closure compiler warnings. (#3156)

ampproject · May 9, 2016 · f2acf80 · f2acf80
1 parent 7c65108
commit f2acf80
Show file tree

Hide file tree

Showing 6 changed files with 50 additions and 48 deletions.
diff --git a/extensions/amp-analytics/0.1/instrumentation.js b/extensions/amp-analytics/0.1/instrumentation.js
@@ -232,7 +232,7 @@ export class InstrumentationService {
     }
   }
 
-  /** @private{function()} function to run or schedule. */
+  /** @private {function()} fn function to run or schedule. */
   runOrSchedule_(fn) {
     if (this.viewer_.isVisible()) {
       fn();

diff --git a/extensions/amp-image-lightbox/0.1/amp-image-lightbox.js b/extensions/amp-image-lightbox/0.1/amp-image-lightbox.js
@@ -993,7 +993,7 @@ class AmpImageLightbox extends AMP.BaseElement {
     });
   }
 
-  /** @private {!History} */
+  /** @private @return {!History} */
   getHistory_() {
     return historyFor(this.element.ownerDocument.defaultView);
   }

diff --git a/src/3p-frame.js b/src/3p-frame.js
@@ -117,6 +117,7 @@ export function getIframe(parentWindow, element, opt_type) {
   iframe.height = attributes.height;
   iframe.style.border = 'none';
   iframe.setAttribute('scrolling', 'no');
+  /** @this {!Element} */
   iframe.onload = function() {
     // Chrome does not reflect the iframe readystate.
     this.readyState = 'complete';