Optimize Observable

ampproject · Jun 9, 2016 · fde8e14 · fde8e14
1 parent cd03d4e
commit fde8e14
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/observable.js b/src/observable.js
@@ -51,11 +51,9 @@ export class Observable {
  * @param {function(TYPE)} handler Observer's instance.
  */
  remove(handler) {
- for (let i = 0; i < this.handlers_.length; i++) {
- if (handler == this.handlers_[i]) {
- this.handlers_.splice(i, 1);
- break;
- }
+ const index = this.handlers_.indexOf(handler);
+ if (index > -1) {
+ this.handlers_.splice(index, 1);
  }
  }
 
@@ -64,9 +62,11 @@ export class Observable {
  * @param {TYPE} event
  */
  fire(event) {
- this.handlers_.forEach(handler => {
+ const handlers = this.handlers_;
+ for (let i = 0; i < handlers.length; i++) {
+ const handler = handlers[i];
  handler(event);
- });
+ }
  }
 
  /**