Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-video with layout "fill" is broken #10300

Closed
jaspermdegroot opened this issue Jul 7, 2017 · 3 comments
Closed

amp-video with layout "fill" is broken #10300

jaspermdegroot opened this issue Jul 7, 2017 · 3 comments
Labels
Milestone

Comments

@jaspermdegroot
Copy link

jaspermdegroot commented Jul 7, 2017

What's the issue?

amp-video with layout="fill" is missing the source elements inside the generated video element after initialisation. Only after resizing the window they are added and the video can be played.

How do we reproduce the issue?

Test page: https://jsbin.com/soxunut/edit?html,output

Open the test page and you'll see the poster image in the output pane. Resize the pane or the whole browser window and the video will start playing.

The test page uses autoplay but the problem also occurs when adding controls and trying to manually start the video.

When testing with the output-only "live preview" (https://output.jsbin.com/soxunut) I don't see the problem, but the exact same markup tested locally without JS Bin does show the issue. It looks like JS Bin is doing something when initialising the preview that also triggers the source elements being added just like the resize event.

[Update:] Shift + reload often (not always) makes the video start after the reload, but it never works after a regular reload.

What browsers are affected?

Seems to be a problem in all browsers. Tested on:

MacOS / Chrome 59
MacOS / Firefox 54
Android / Chrome 59

Which AMP version is affected?

Tested with AMP version 1499361527811

@aghassemi
Copy link
Contributor

aghassemi commented Jul 7, 2017

Happens with other extended elements as well, not just amp-video. Assessment of root cause on related issue: #9397 (comment)

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

@stale
Copy link

stale bot commented Dec 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Dec 30, 2020
@stale stale bot closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants