Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dailymotion embed doesn't work in Chrome using amp-iframe #1585

Closed
okeul opened this issue Jan 26, 2016 · 13 comments
Closed

Dailymotion embed doesn't work in Chrome using amp-iframe #1585

okeul opened this issue Jan 26, 2016 · 13 comments

Comments

@okeul
Copy link

okeul commented Jan 26, 2016

Currently it's not possible to show Dailymotion video in Chrome but it works in Firefox.

Example : http://codepen.io/okeul/pen/YwZmgo

Chrome 47.0.2526
Firefox 41.0.2 & 43.0.4
OSX 10.8.5 & 10.10.4

@rudygalfi
Copy link
Contributor

Let's use this issue to track the FF/Chrome inconsistency. amp-iframe should work in this context. Opened #1588 for tracking a new DailyMotion component.

@rudygalfi rudygalfi changed the title Add support for Dailymotion Dailymotion embed doesn't work in Chrome using amp-iframe Jan 26, 2016
@cramforce
Copy link
Member

I'm all for a dedicated dailymotion embed.
From some casual testing I'm not sure we can fix the Chrome issue. See http://output.jsbin.com/bejeze for a non-AMP page (just a naive iframe) with the same problem. Maybe this is the wrong URL for them?

@okeul
Copy link
Author

okeul commented Jan 26, 2016

Thanks for your quick answer !

@cramforce : You're almost right, there is a problem with https & dailymotion. It works in http but not in https :
Example for a no-AMP page : http://codepen.io/okeul/pen/qboMRQ

@rudygalfi rudygalfi added the 3P label Jan 26, 2016
@johnnyshankman
Copy link

So currently there is no solution for Dailymotion, as HTTPS is unreliable as a src even for regular <iframe> tags? Am I reading this back right? Or is it just a Chrome-centric issue?

I also could not get an iframe to work over HTTPS with dailymotion nor amp-iframe.

@johnnyshankman
Copy link

Can confirm that the same <amp-iframe> that does not work in Desktop Chrome or Desktop Safari works just fine in iOS9 Safari and my mobile version of Chrome for iOS9.

img_6520

@johnnyshankman
Copy link

Looks to me like it's an issue with Flash inside of the iframe. Because the iframe is sandboxed, we cannot execute Flash within the iframe.

On my mobile device it seems to be working because it's forcing an HTML5 fallback player instead of the flash player. Anyone else see this happening?

@okeul
Copy link
Author

okeul commented Jan 26, 2016

@johnnyshankman : That can be right, it's the same for me. It works on my mobile with Dailymotion & https (AMP & no-AMP).

Android 6.0.1 / Chrome 47

@cramforce
Copy link
Member

Yes, flash will not work inside amp-iframe.

A specific amp embed for dailymotion or AOL would not have this limitation.

@cramforce
Copy link
Member

Could somebody contact dailymotion and/or AOL whether they e.g. support a URL param to opt out of the flash player?

@okeul
Copy link
Author

okeul commented Jan 27, 2016

I tried to reach the technical support of Dailymotion. I haven't received any responses yet.

@rudygalfi rudygalfi added this to the M1 milestone Jan 28, 2016
@zeno
Copy link
Contributor

zeno commented Jan 29, 2016

Hi guys, we are in contact with Google and working on a specific amp-dailymotion component.

@zeno
Copy link
Contributor

zeno commented Feb 16, 2016

See #2017.

@jridgewell
Copy link
Contributor

Closed by #2017, pending #1732 to pass validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants