Dailymotion player component

[zeno]

Add amp-dailymotion component to display a Dailymotion video.

Include tests, documentation and example file.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[cramforce]

The mixed - and _ feels a bit weird.

[cramforce]

This looks great!

We've currently porting the video players to show a poster during pre-rendering (amp-video done, amp-youtube in progress). We should not do this in this change, but it would be great if we could do that in the future. It would require a predictable URL for a poster image of the video.

[googlebot]

CLAs look good, thanks!

[zeno]

Thx for the feedback @cramforce. Just committed some changes.
Sure, showing poster during pre-rendering via a predictable URL to avoid extra request shouldn't be a problem.

[cramforce]

Looks great. Two more things

1. please add your file here https://github.com/ampproject/amphtml/blob/master/test/integration/test-example-validation.js#L55 and whitelist the error here https://github.com/ampproject/amphtml/blob/master/test/integration/test-example-validation.js#L72
2. Squash your commits to a single commit.

I added your component to #1732. It should start validating in the next few days.

[zeno]

Done.

Thanks @cramforce

[cramforce]

LGTM
Awesome! Will merge when travis is green.

[ndachez]

Hello , I tried to implement "amp- dailymotion" but I still encounter some errors. The video displays correctly... In Chrome console, I have 2 errors :

1. The attribute 'custom-element' in tag 'amp-access extension .js script' is set to the invalid value 'amp-dailymotion'
2. The tag 'amp-dailymotion' is disallowed.

The link : http://amp.chien.fr/actualite/cristina-cordula-m6-affirme-je-ne-suis-pas-contre-la-fourrure/#development=1

Thx.

[cramforce]

This should become valid within the day.

On Fri, Feb 19, 2016 at 4:53 AM, ndachez notifications@github.com wrote:

Hello , I tried to implement "amp- dailymotion" but I still encounter some
errors. The video displays correctly... In Chrome console, I have 2 errors :

1. The attribute 'custom-element' in tag 'amp-access extension .js
   script' is set to the invalid value 'amp-dailymotion'
2. The tag 'amp-dailymotion' is disallowed.

The link :
http://amp.chien.fr/actualite/cristina-cordula-m6-affirme-je-ne-suis-pas-contre-la-fourrure/#development=1

Thx.

—
Reply to this email directly or view it on GitHub
#2017 (comment).

[ndachez]

Thx cramforce !

Indeed, I have the little message : "Powered by AMP ⚡ HTML – Version 1455904100660 / AMP validation successful."

Have a nice day :)

[okeul]

Hi !

This component works well but there are several errors in the console when the video is playing :

Example :
http://output.jsbin.com/dokosa/#development=1