-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA error: null is not an object (evaluating 'e.ownerNode') #17024
Comments
I think this issue appeared after this commit: #15204 |
@juanchaur1 Thanks for the report. Sorry about the regression. /to @jridgewell Setting to P1 for now since breakage is limited to certain user interactions on PWA+AMP. If anyone believes this should be P0, please let us know. |
/to @choumx (@jridgewell is OOO) |
This issue doesn't have a category which makes it harder for us to keep track of it. @jridgewell Please add an appropriate category. |
This is a high priority issue but it hasn't been updated in awhile. @jridgewell Do you have any updates? |
I can't find any traces in our "origin" error reports with "ownerNode" and it's strange that Should be easy enough to add a null check to the loop though. |
This is a high priority issue but it hasn't been updated in awhile. @jridgewell Do you have any updates? |
3 similar comments
This is a high priority issue but it hasn't been updated in awhile. @jridgewell Do you have any updates? |
This is a high priority issue but it hasn't been updated in awhile. @jridgewell Do you have any updates? |
This is a high priority issue but it hasn't been updated in awhile. @jridgewell Do you have any updates? |
@alabiaga Let's add that null-check as described in #17024 (comment). |
What's the issue?
In a multi shadow dow when swiping fast in an iOS device, the document doesn't initialize correctly causing the fix-layer to have a list of stylesheets with null values.
I believe there should be a check here:
https://github.com/ampproject/amphtml/blob/master/src/service/fixed-layer.js#L110
How do we reproduce the issue?
You can go to: https://www.starwarsnewsnet.com/2018/07/san-diego-comic-con-2018-preview-of-star-wars-related-content-and-our-sdcc-exclusive-giveaways.html
and swipe fast or use the next-article button
What browsers are affected?
Safari (any iphone)
And also emulating a mobile device in safari desktop.
Which AMP version is affected?
last one
The text was updated successfully, but these errors were encountered: