Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer code clean ups #17679

Closed
3 tasks done
lannka opened this issue Aug 23, 2018 · 0 comments
Closed
3 tasks done

Viewer code clean ups #17679

lannka opened this issue Aug 23, 2018 · 0 comments
Assignees
@lannka
Labels
P2: Soon WG: viewers

Comments

@lannka
Copy link
Contributor

lannka commented Aug 23, 2018 •
edited
Loading

More clean ups in addition to #17590

  • whenMessagingReady() is not needed because sendMessage() already wait for the channel.
  • too many promise objects messagingReadyResolver_ trustedViewerResolver_ viewerOriginResolver_, which are all resolved when the messaging channel is ready.
  • messagingMaybePromise_ is not needed. it is likely a left-over from a previous refactoring Refactor sendMessage and sendMessageAwaitResponse #6508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lannka lannka

Labels
P2: Soon WG: viewers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lannka