Refactor sendMessage and sendMessageAwaitResponse #6508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muxin
force-pushed
the
refactor-awaitResponse
branch
3 times, most recently
from
726dcf4
to
0389fe3
Compare
muxin
force-pushed
the
refactor-awaitResponse
branch
from
0389fe3
to
c25b98b
Compare
muxin
force-pushed
the
refactor-awaitResponse
branch
from
ea7fd00
to
f0e3f91
Compare
lannka
approved these changes
Dec 7, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
This was referenced Aug 23, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
sendMessageandsendMessageCancelUnsentinviewer-implintosendMessage(eventType, data, cancelUnsent): no return valuesendMessageAwaitResponse(eventType, data, cancelUnsent): wait for the response and return a promise