amp-bind fails to initialize in PWA

[mattwomple]

What's the issue?

amp-bind does not work on the first AMP page loaded into a PWA since release 1910251950120 . It fails to initialize due to a hung promise:

amphtml/extensions/amp-bind/0.1/bind-impl.js

Lines 596 to 600 in b63d17b

	const whenParsed = toArray(ampStates).map(el => {
	return whenUpgradedToCustomElement(el)
	.then(() => el.getImpl(whenBuilt))
	.then(impl => impl.parseAndUpdate());
	});

How do we reproduce the issue?

Minimal example AMP and PWA available:

• Bind works: https://android.cmphys.com/temp/bind-init-fail-amp.html
• Bind does not work: https://android.cmphys.com/temp/bind-init-fail-pwa.html

What browsers are affected?

Chrome 78 Windows and Linux tested

Which AMP version is affected?

1910251950120

[mattwomple]

/CC @jridgewell I'm just starting to investigate this now, but wanted to ping you in case this has anything to do with custom elements polyfill v1 that was included in 1910251950120. If you could tag relevant people to this issue report it would be much appreciated as it affects a large number of WompMobile PWAs.

[mattwomple]

this.whenUpgradedToCustomElement(el) never resolves because nothing ever calls .__AMP_UPG_RES() on the <amp-state> element in the page... which seems to be due to <amp-state> simply not getting upgraded to a custom element.

[jridgewell]

Looking now

[jridgewell]

Found the problem, working on a fix now.

[mattwomple]

I'm a little slower than you, but I think I see. const upgradeCandidates = this.queryAll_(root, query); identifies 0 nodes that can be updated in the upgrade() method in custom-elements.js. Maybe?

[jridgewell]

Yup, I was querying only the document and not the individual shadows.