Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Story fails to build #25351

Closed
newmuis opened this issue Oct 31, 2019 · 3 comments
Closed

Story fails to build #25351

newmuis opened this issue Oct 31, 2019 · 3 comments
Assignees
@gmajoulet
Labels
P1: High Priority Type: Bug WG: stories

Comments

@newmuis
Copy link
Contributor

newmuis commented Oct 31, 2019 •
edited
Loading

Seems like stories sometimes completely fail to build, leaving the page rendered vertically.

JavaScript console claims that the page timed out waiting for amp-story-render service to be ready.

/cc @ampproject/wg-stories
@newmuis newmuis self-assigned this Oct 31, 2019
@newmuis newmuis changed the title Story fails to load JS or CSS Story fails to build Oct 31, 2019
@newmuis
Copy link
Contributor Author

newmuis commented Oct 31, 2019

Trying to figure out a consistent repro case.

@newmuis
Copy link
Contributor Author

newmuis commented Oct 31, 2019

I can't tell if it's the new release (1910302211460) or just a heisenbug, but I can't repro this at all anymore. Lowering to P1 to keep an eye on it.

I was able to repro this at least sometimes in 1910251950120, so perhaps this was another effect of #25332 (since the PR which resolves that is the only difference between 1910251950120 and 1910302211460).

@gmajoulet gmajoulet assigned gmajoulet and unassigned newmuis Nov 1, 2019
@gmajoulet
Copy link
Contributor

I forgot what the fix was but it's been verified with 3p publishers who could repro very often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmajoulet gmajoulet

Labels
P1: High Priority Type: Bug WG: stories
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmajoulet @newmuis