Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2I: amp-next-page v2 #25826

Closed
wassgha opened this issue Dec 2, 2019 · 4 comments
Closed

I2I: amp-next-page v2 #25826

wassgha opened this issue Dec 2, 2019 · 4 comments
Assignees
Labels
Component: amp-next-page INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P1: High Priority WG: components

Comments

@wassgha
Copy link
Contributor

wassgha commented Dec 2, 2019

Summary

This is the second phase of #25500 , proposes a second version of the amp-next-page component that breaks the initial API in order to allow for true infinitely scrolling AMP documents as well as substantial fixes to the initial extension.

Design document

Design document

Motivation

The status quo is that amp-next-page v1 is launched as doc-level opt-in only (but is significantly in usage) and only provides next document loading up to three "next documents". Demand dictates a truly infinite document loading experience as well as multiple fixes to the extension and a simpler API (see #24889 ). Since the API changes would be breaking (and given that amp-next-page v1 never launched in a production ready state), it might be appropriate to launch as v2 (either 0.2 or 1.0) once all issues are fixed and the API is final.

Additional context

More context in the design doc, the master issue and an external contribution at #24889 . Partially started implementation under #25636 .

Launch tracker

Launch tracker

@wassgha wassgha added the INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code label Dec 2, 2019
@wassgha wassgha self-assigned this Dec 3, 2019
@davidstrauss
Copy link
Contributor

Can you please make this design document accessible to the public?

@davidstrauss
Copy link
Contributor

The launch tracker document appears to need a publicly accessible version as well.

@kristoferbaxter
Copy link
Contributor

I was able to access the design document from a non-logged in account, was this changed after design review?

@wassgha
Copy link
Contributor Author

wassgha commented Dec 5, 2019

I had an issue with my amp.dev account but I was able to resolve it right before the meeting. No worries though, I'll continue working on this and implement changes if needed after the next meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: amp-next-page INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P1: High Priority WG: components
Projects
None yet
Development

No branches or pull requests

3 participants