I2I: Multi-selector support for visibility trigger #26823

micajuine-ho · 2020-02-14T23:04:30Z

Follow up to #11380.

NOTE: This only applies to visibility triggers as well as static content (i.e. no mustache template selectors, no dynamic content). At this time, visibility triggers only work for amp-elements.

Summary

Multi-selector support: Add support for a single visibility trigger to support multiple selectors
QuerySelectorAll support: Add support for a visibility trigger’s selector(s) to track all elements have the selector(s) (instead of the first element)

Design document

External Doc

Design Proposal

Multi-selector: Add array support for the selector field within a visibility trigger
QuerySelectorAll: All selectors within the multi-selector array will be treated as querySelectorAll
Restrict listeners (and requests) for elements that do not have a data-var-* attribute

See the design doc above for details.

Motivation

In amp-analytics, it is hard for publishers to track the visibility of elements that share selectors. Our current implementation only allows a one-to-one mapping between a single element and visibility trigger. This presents a challenge for publishers who would like to track the visibility of all similar elements, such as all amp-ads ~~or all paragraphs in an article~~.

Launch tracker

Feature Flag ✨ Array multi-selector visibility trigger #26862
Multi-selector ✨ Array multi-selector visibility trigger #26862
querySelectorAll ✨ Visibility trigger support for querySelectorAll #26886
Restrict unique requests ✨ Require visibility trigger selector's to have data-vars-* #26902
Turn on experiment in Canary Turn on visibility-trigger-improvments experiment in canary #30861
Turn on experiment in Prod Turn on visibility-trigger-improvements experiment in prod #31066
Document Changes 📖 Visibility trigger multi-selector doc #26911
Clean up

/cc @lannka @zhouyx

The text was updated successfully, but these errors were encountered:

zhouyx · 2020-02-14T23:18:07Z

Thank you @micajuine-ho this is going to save a lot of configurations!
Could you please highlight the format of the chosen proposal.

micajuine-ho · 2020-02-19T19:21:39Z

Could you please highlight the format of the chosen proposal.

Updated!

enderton · 2020-10-09T19:47:05Z

Hello! We've been following this issue, and are very excited for these changes to improve our impression analytics logic (and have tried it locally in development). Is there a known timeline for when the experiment flag will be removed (for the querySelectorAll portion)? Thanks.

micajuine-ho · 2020-10-09T20:13:05Z

Hi @enderton, have you used this feature with the experiment flag on?

enderton · 2020-10-09T21:11:22Z

Yes - in local and staged environments, yes (via toggling in dev tools AMP.toggleExperiment('visibility-trigger-improvements').

Is not yet in production code served by AMP CDN, so have not used https://amp.dev/documentation/guides-and-tutorials/learn/experimental/#served-from-cdn.ampproject.org.

It's our understanding that we could not enable this experiment for all users, so have held off making part of production code.

Sweep experiments last flipped globally up to 2023-03-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2023-04-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2023-05-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2023-06-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2023-07-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2023-08-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2023-09-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2023-10-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2023-11-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2023-12-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2024-01-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

Sweep experiments last flipped globally up to 2024-02-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ### ⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ### ⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)

micajuine-ho added the INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code label Feb 14, 2020

micajuine-ho self-assigned this Feb 14, 2020

micajuine-ho mentioned this issue Feb 19, 2020

✨ Array multi-selector visibility trigger #26862

Merged

This was referenced Feb 20, 2020

✨ Visibility trigger support for querySelectorAll #26886

Merged

✨ Require visibility trigger selector's to have data-vars-* #26902

Merged

📖 Visibility trigger multi-selector doc #26911

Merged

[WIP] Visibility trigger for non-amp elements #26995

Closed

micajuine-ho mentioned this issue Feb 28, 2020

More Visibility Trigger improvements #27029

Closed

dreamofabear added the WG: analytics label Mar 3, 2020

zhouyx mentioned this issue Jun 10, 2020

wg-analytics Quarterly Status Update 2020-06 ampproject/wg-analytics#25

Closed

micajuine-ho mentioned this issue Jun 18, 2020

I2I: "Browsi" amp-analytics & RTC vendors #26688

Closed

micajuine-ho mentioned this issue Jul 7, 2020

Visibility Trigger for Non AMP Elements #29172

Merged

micajuine-ho mentioned this issue Oct 26, 2020

Turn on visibility-trigger-improvments experiment in canary #30861

Merged

This was referenced Nov 23, 2020

Turn on amp-cid-backup experiment in prod #31298

Merged

Turn on visibility-trigger-improvements experiment in prod #31066

Merged

micajuine-ho mentioned this issue Mar 24, 2021

amp-analytics: gtag vendor config rewriter payload size limitation #32911

Open

micajuine-ho mentioned this issue Jun 22, 2021

🚮[amp-analytics] Clean up visibility trigger improvement experiment #34950

Merged

kristoferbaxter closed this as completed Jun 22, 2021

github-actions bot mentioned this issue Mar 1, 2024

🚮 Sweep experiments older than 2023-03-01 mohammed-ibra/amphtml#423

Draft

23 tasks

github-actions bot mentioned this issue Apr 1, 2024

🚮 Sweep experiments older than 2023-04-01 mohammed-ibra/amphtml#431

Draft

23 tasks

github-actions bot mentioned this issue May 1, 2024

🚮 Sweep experiments older than 2023-05-01 mohammed-ibra/amphtml#435

Draft

23 tasks

github-actions bot mentioned this issue Jun 1, 2024

🚮 Sweep experiments older than 2023-06-01 mohammed-ibra/amphtml#436

Draft

23 tasks

github-actions bot mentioned this issue Jul 1, 2024

🚮 Sweep experiments older than 2023-07-01 mohammed-ibra/amphtml#437

Draft

23 tasks

github-actions bot mentioned this issue Aug 1, 2024

🚮 Sweep experiments older than 2023-08-01 mohammed-ibra/amphtml#438

Draft

23 tasks

github-actions bot mentioned this issue Sep 1, 2024

🚮 Sweep experiments older than 2023-09-01 mohammed-ibra/amphtml#440

Draft

23 tasks

github-actions bot mentioned this issue Oct 1, 2024

🚮 Sweep experiments older than 2023-10-01 mohammed-ibra/amphtml#446

Draft

23 tasks

github-actions bot mentioned this issue Nov 1, 2024

🚮 Sweep experiments older than 2023-11-01 mohammed-ibra/amphtml#448

Draft

23 tasks

github-actions bot mentioned this issue Dec 1, 2024

🚮 Sweep experiments older than 2023-12-01 mohammed-ibra/amphtml#456

Draft

23 tasks

github-actions bot mentioned this issue Jan 1, 2025

🚮 Sweep experiments older than 2024-01-01 mohammed-ibra/amphtml#457

Draft

23 tasks

github-actions bot mentioned this issue Feb 1, 2025

🚮 Sweep experiments older than 2024-02-01 mohammed-ibra/amphtml#458

Draft

23 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

I2I: Multi-selector support for visibility trigger #26823

I2I: Multi-selector support for visibility trigger #26823

micajuine-ho commented Feb 14, 2020 •

edited

Loading

zhouyx commented Feb 14, 2020

micajuine-ho commented Feb 19, 2020

enderton commented Oct 9, 2020

micajuine-ho commented Oct 9, 2020

enderton commented Oct 9, 2020

I2I: Multi-selector support for visibility trigger #26823

I2I: Multi-selector support for visibility trigger #26823

Comments

micajuine-ho commented Feb 14, 2020 • edited Loading

Summary

Design document

Design Proposal

Motivation

Launch tracker

zhouyx commented Feb 14, 2020

micajuine-ho commented Feb 19, 2020

enderton commented Oct 9, 2020

micajuine-ho commented Oct 9, 2020

enderton commented Oct 9, 2020

micajuine-ho commented Feb 14, 2020 •

edited

Loading