Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid listnenFor after appending an iframe #2944

Closed
jridgewell opened this issue Apr 19, 2016 · 0 comments
Closed

Forbid listnenFor after appending an iframe #2944

jridgewell opened this issue Apr 19, 2016 · 0 comments
Assignees
@jridgewell
Milestone
Fixit Week February

Comments

@jridgewell
Copy link
Contributor

Forking from #2942, we should forbid using listenFor (aka, listen in iframe-helper.js) after the iframe has been appended (at least in dev mode). This will catch bugs before I spend 2 days in iframe hell debugging things.
@jridgewell jridgewell self-assigned this Apr 19, 2016
jridgewell added a commit to jridgewell/amphtml that referenced this issue Apr 19, 2016
@jridgewell
Forbid adding event listeners on appended iframes
765c5a7 
Fixes ampproject#2944.
@jridgewell jridgewell mentioned this issue Apr 19, 2016
Merged
@ericlindley-g ericlindley-g added this to the Fixit - Date TBD milestone Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jridgewell jridgewell

Labels
None yet
Projects
None yet
Milestone
Fixit Week February
Development

No branches or pull requests
2 participants
@jridgewell @ericlindley-g