Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Error: viewport has zero dimensions #31663

Closed
ampprojectbot opened this issue Dec 18, 2020 · 6 comments
Closed

🚨 Error: viewport has zero dimensions #31663

ampprojectbot opened this issue Dec 18, 2020 · 6 comments
Labels
Type: Error Report An error reported by AMP Error Reporting

Comments

@ampprojectbot
Copy link
Member

Details

Error report: link
First seen: Dec 4, 2020
Frequency: ~ NaN/day

Stacktrace

Error: viewport has zero dimensions
    at src/utils/promise.js:74:2
    at src/log.js:477:4
    at shouldBeArray (src/log.js:511:14)
    at getScrollHeight (src/service/viewport/viewport-impl.js:313:2)
    at signal (src/service/resources-impl.js:828:28)
    at on (src/input.js:183:37)
    at delay (src/pass.js:94:36)
    at this (src/service/timer-impl.js:118:15)

Notes

@renovate-bot modified src/utils/promise.js:74-74 in #27350 (Mar 30, 2020)
@cramforce modified src/log.js:477-479 in #4908 (Sep 10, 2016)
@cathyxz modified src/log.js:510-511 in #19937 (Dec 26, 2018)
@choumx modified src/service/resources-impl.js:823-832 in #26236 (Mar 9, 2020)
@lannka modified src/input.js:181-187 in #25404 (Nov 4, 2019)
@cramforce modified src/pass.js:94-94 in #3904 (Jul 6, 2016)
@renovate-bot modified src/service/timer-impl.js:118-118 in #27350 (Mar 30, 2020)

Seen in:

  • 12-04 Nightly (0327)

Possible assignees: @choumx, @lannka

/cc @ampproject/release-on-duty

@ampprojectbot ampprojectbot added the Type: Error Report An error reported by AMP Error Reporting label Dec 18, 2020
@caroqliu
Copy link
Contributor

would folks in @ampproject/wg-performance be familiar with this? FYI @rcebulko looks like this is counting as NaN/day

@rcebulko
Copy link
Contributor

This appears to be a dupe of the longstanding bug #8926
The link no longer leads to an error entry. Given that it only appeared in that one Nightly build, I'd guess that it was just the version of this error that popped up for that specific build (and was not grouped due to a known and fixed issue with ESM sourcemaps that has yet to roll out). I'd lean toward closing this on and bumping the original

@caroqliu
Copy link
Contributor

@rcebulko I didn't dedupe with other bug since the stack trace looks different. Folks who are more familiar with #8926 should take a look and close this issue if needed.

@samouri
Copy link
Member

samouri commented Dec 23, 2020

Following the error report link isn't working for me (yes, I'm signed in). Is it working for others?

@caroqliu
Copy link
Contributor

Following the error report link isn't working for me (yes, I'm signed in). Is it working for others?

Hm, not working for me either.

Error not found
The requested error has not been reported within this project.

@rcebulko
Copy link
Contributor

rcebulko commented Dec 23, 2020

This can happen with errors that have very low or temporary presence. In this case, it looks like it was a duplicate of an existing error, but with a unique stacktrace to to the ESM sourcemap bug (fixed in #31602). Stackdriver will only maintain the top 10k most frequent error-RTV tuples, so something like this in nightly popped up and was reported, but soon after was pruned from Stackdriver (hence the NaN and dead link). Unfortunately I don't believe there's anything we can do about this on our end, but it shouldn't be an issue often as the sourcemap fix rolls out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Error Report An error reported by AMP Error Reporting
Projects
None yet
Development

No branches or pull requests

5 participants