Do not execute pass callbacks if their window went away. #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could happen in tests if multiple windows had different lifetime. Also turns timer into a service but does not yet fix all callsites. Fixes ampproject#3709 but all the other timer usages could lead to similar issues.
|
LGTM |
|
Did this fix #3315 by any chance? |
|
@mkhatib I haven't tried, but it might. |
|
CC @dvoytenko FYI |
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
…3904) This could happen in tests if multiple windows had different lifetime. Also turns timer into a service but does not yet fix all callsites. Fixes ampproject#3709 but all the other timer usages could lead to similar issues.
This was referenced Jul 16, 2020
This was referenced Dec 18, 2020
This was referenced Dec 30, 2020
This was referenced Mar 4, 2021
This was referenced Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen in tests if multiple windows had different lifetime. Also turns timer into a service but does not yet fix all callsites.
Fixes #3709 but all the other timer usages could lead to similar issues.