Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why cleaning up iframes break integration tests on Safari #3315

Closed
mkhatib opened this issue May 24, 2016 · 2 comments
Closed

Investigate why cleaning up iframes break integration tests on Safari #3315

mkhatib opened this issue May 24, 2016 · 2 comments
Assignees

Comments

@mkhatib
Copy link
Contributor

mkhatib commented May 24, 2016

Currently in _init_tests.js we remove all test iframes to allow chrome to collect the memory. We only do this on Chrome because tests on Safari seems to break.

@mkhatib mkhatib added this to the Backlog milestone May 24, 2016
@mkhatib mkhatib modified the milestones: Fixit - Date TBD, Backlog Jun 10, 2016
@mkhatib mkhatib added the FixIt label Jun 10, 2016
@cramforce
Copy link
Member

I think this is because of #3709

@adelinamart
Copy link
Contributor

Hey,

The AMP community has been working nonstop to make AMP better, but somehow we've still managed to grow an enormous backlog of open issues. This has made it difficult for the community to prioritize what we should work on next.

A new process is on the way and to give it a chance for success we will be closing issues that have not been updated in awhile.

If this issue still requires further attention, simply reopen it. Please try to reproduce it with the latest version to ensure it gets proper attention!

We really appreciate the contribution! Thank you for bearing with us as we drag ourselves out of the issue abyss. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants