Cleanup iframes when running tests on chrome. #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhatib
force-pushed
the
remove-test-iframes
branch
from
d2277e9 to
dac0cd1
Compare
mkhatib
force-pushed
the
remove-test-iframes
branch
from
dac0cd1 to
fbeeb94
Compare
| @@ -76,7 +77,12 @@ sinon.sandbox.create = function(config) { | |||
| // Global cleanup of tags added during tests. Cool to add more | |||
| // to selector. | |||
| afterEach(() => { | |||
| const cleanup = document.querySelectorAll('link,meta'); | |||
| const cleanupTagNames = ['link', 'meta']; | |||
| if (platform.isChrome()) { | |||
There was a problem hiding this comment.
It was, Github sometimes doesn't seem to update the diff view for some reason. Now updated.
|
LGTM |
This was referenced Jun 2, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes test iframes to address some of the issues with memory leaks #3138